linux-kernel - RE: 回复: 回复: Re: [PATCH v20 3/5] usb: misc: Add onboard_usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM8PR02MB81988555CA6B66BB3FD5E488E3019@DM8PR02MB8198.namprd02.prod.outlook.com>
Date:   Mon, 28 Feb 2022 03:08:34 +0000
From:   "Linyu Yuan (QUIC)" <quic_linyyuan@...cinc.com>
To:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "Tao Wang (Consultant) (QUIC)" <quic_wat@...cinc.com>
CC:     "mka@...omium.org" <mka@...omium.org>,
        "balbi@...nel.org" <balbi@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "dianders@...omium.org" <dianders@...omium.org>,
        "frowand.list@...il.com" <frowand.list@...il.com>,
        "hadess@...ess.net" <hadess@...ess.net>,
        "krzk@...nel.org" <krzk@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "mathias.nyman@...el.com" <mathias.nyman@...el.com>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "peter.chen@...nel.org" <peter.chen@...nel.org>,
        "ravisadineni@...omium.org" <ravisadineni@...omium.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "rogerq@...nel.org" <rogerq@...nel.org>,
        "stern@...land.harvard.edu" <stern@...land.harvard.edu>,
        "swboyd@...omium.org" <swboyd@...omium.org>,
        "Linyu Yuan (QUIC)" <quic_linyyuan@...cinc.com>
Subject: RE: 回复: 回复: Re: [PATCH v20 3/5] usb: misc: Add onboard_usb_hub driver

> From: gregkh@...uxfoundation.org <gregkh@...uxfoundation.org>
> Sent: Wednesday, February 23, 2022 3:56 PM
> To: Tao Wang (Consultant) (QUIC) <quic_wat@...cinc.com>
> Cc: mka@...omium.org; balbi@...nel.org; devicetree@...r.kernel.org;
> dianders@...omium.org; frowand.list@...il.com; hadess@...ess.net;
> krzk@...nel.org; linux-kernel@...r.kernel.org; linux-usb@...r.kernel.org;
> mathias.nyman@...el.com; michal.simek@...inx.com;
> peter.chen@...nel.org; ravisadineni@...omium.org; robh+dt@...nel.org;
> rogerq@...nel.org; stern@...land.harvard.edu; swboyd@...omium.org;
> Linyu Yuan (QUIC) <quic_linyyuan@...cinc.com>
> Subject: Re: 回复: 回复: Re: [PATCH v20 3/5] usb: misc: Add
> onboard_usb_hub driver
> 
> On Wed, Feb 23, 2022 at 07:40:31AM +0000, Tao Wang (Consultant) (QUIC)
> wrote:
> > Ok, thanks your reply.
> >
> > Here is my question, we must modify the driver "onboard_usb_hub.c" if
> we want to use it. But it's hard to complete because it's an opensource code.
> 
> I do not understand.  We do not deal with code that is not in the kernel
> source tree, as we have no idea what is out there.  Please just submit
> your changes to be merged into the tree and all will be fine.

Hi Greg and mka,

Let's make it clear that we are talking about once this driver is approved into usb tree,
If we use different USB HUB which have VID/PID not defined in this driver,
We need to update this driver.

But if we defined VID/PID in device tree(for a specific board, manufacture should know VID/PID from HUB it used),
dynamic parsed by the driver,  then we don't need to change this driver (increase VID/PID table).

> 
> thanks,
> 
> greg k-h