linux-kernel - Re: [RESEND PATCH 2/2] tracing: Avoid isolated CPUs when queueing fsnotify irqwork

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9194bc573ec0ccd2d3842ffd4a76894d683a197d.camel@redhat.com>
Date:   Mon, 28 Feb 2022 19:20:13 +0100
From:   Nicolas Saenz Julienne <nsaenzju@...hat.com>
To:     kernel test robot <lkp@...el.com>, mingo@...hat.com,
        peterz@...radead.org, frederic@...nel.org, rostedt@...dmis.org
Cc:     kbuild-all@...ts.01.org, tglx@...utronix.de, mtosatti@...hat.com,
        bristot@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH 2/2] tracing: Avoid isolated CPUs when queueing
 fsnotify irqwork

On Tue, 2022-03-01 at 02:07 +0800, kernel test robot wrote:
> Hi Nicolas,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on tip/sched/core]
> [also build test ERROR on next-20220225]
> [cannot apply to rostedt-trace/for-next linus/master v5.17-rc6]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Nicolas-Saenz-Julienne/sched-isolation-Use-raw_smp_processor_id-in-housekeeping_any_cpu/20220228-221742
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 6255b48aebfd4dff375e97fc8b075a235848db0b
> config: mips-allyesconfig (https://download.01.org/0day-ci/archive/20220301/202203010138.m94KpMH3-lkp@intel.com/config)
> compiler: mips-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/e3ec0b4adfed05db0d559d2d5234d6d8f1034985
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Nicolas-Saenz-Julienne/sched-isolation-Use-raw_smp_processor_id-in-housekeeping_any_cpu/20220228-221742
>         git checkout e3ec0b4adfed05db0d559d2d5234d6d8f1034985
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=mips SHELL=/bin/bash kernel/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>    kernel/trace/trace.c: In function 'latency_fsnotify':
> > > kernel/trace/trace.c:1728:71: error: 'HK_FLAG_MISC' undeclared (first use in this function); did you mean 'HK_TYPE_MISC'?
>     1728 |         irq_work_queue_on(&tr->fsnotify_irqwork, housekeeping_any_cpu(HK_FLAG_MISC));
>          |                                                                       ^~~~~~~~~~~~
>          |                                                                       HK_TYPE_MISC
>    kernel/trace/trace.c:1728:71: note: each undeclared identifier is reported only once for each function it appears in
>    kernel/trace/trace.c: In function 'trace_check_vprintf':
>    kernel/trace/trace.c:3827:17: warning: function 'trace_check_vprintf' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
>     3827 |                 trace_seq_vprintf(&iter->seq, iter->fmt, ap);
>          |                 ^~~~~~~~~~~~~~~~~
>    kernel/trace/trace.c:3894:17: warning: function 'trace_check_vprintf' might be a candidate for 'gnu_printf' format attribute [-Wsuggest-attribute=format]
>     3894 |                 trace_seq_vprintf(&iter->seq, p, ap);
>          |                 ^~~~~~~~~~~~~~~~~
> 
> 
> vim +1728 kernel/trace/trace.c
> 
>   1718	
>   1719	void latency_fsnotify(struct trace_array *tr)
>   1720	{
>   1721		if (!fsnotify_wq)
>   1722			return;
>   1723		/*
>   1724		 * We cannot call queue_work(&tr->fsnotify_work) from here because it's
>   1725		 * possible that we are called from __schedule() or do_idle(), which
>   1726		 * could cause a deadlock.
>   1727		 */
> > 1728		irq_work_queue_on(&tr->fsnotify_irqwork, housekeeping_any_cpu(HK_FLAG_MISC));
>   1729	}
>   1730	

It seems my patch conflicts with:

04d4e665a609 ("sched/isolation: Use single feature type while referring to housekeeping cpumask")

I'll rebase and send a v2.

-- 
Nicolás Sáenz