linux-kernel - Re: [PATCH v2] Input: samsung-keypad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YhxW89ZYH6KgruvI@google.com>
Date:   Sun, 27 Feb 2022 21:00:35 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     David Gow <davidgow@...gle.com>
Cc:     Joonyoung Shim <jy0922.shim@...sung.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-um@...ts.infradead.org,
        anton ivanov <anton.ivanov@...bridgegreys.com>
Subject: Re: [PATCH v2] Input: samsung-keypad - Properly state IOMEM
 dependency

On Fri, Feb 25, 2022 at 12:17:27PM +0800, David Gow wrote:
> Make the samsung-keypad driver explicitly depend on CONFIG_HAS_IOMEM, as it
> calls devm_ioremap(). This prevents compile errors in some configs (e.g,
> allyesconfig/randconfig under UML):
> 
> /usr/bin/ld: drivers/input/keyboard/samsung-keypad.o: in function `samsung_keypad_probe':
> samsung-keypad.c:(.text+0xc60): undefined reference to `devm_ioremap'
> 
> Signed-off-by: David Gow <davidgow@...gle.com>
> Acked-by: anton ivanov <anton.ivanov@...bridgegreys.com>

Applied, thank you.

-- 
Dmitry