[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202203010527.LaNAQMXX-lkp@intel.com>
Date: Tue, 1 Mar 2022 05:51:57 +0800
From: kernel test robot <lkp@...el.com>
To: Won Chung <wonchung@...gle.com>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J . Wysocki" <rafael@...nel.org>,
Benson Leung <bleung@...omium.org>,
Prashant Malani <pmalani@...omium.org>,
linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: kbuild-all@...ts.01.org, Won Chung <wonchung@...gle.com>
Subject: Re: [PATCH] usb:typec: Add sysfs support for Type C connector's
physical location
Hi Won,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on chrome-platform/for-next linus/master v5.17-rc6 next-20220228]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Won-Chung/usb-typec-Add-sysfs-support-for-Type-C-connector-s-physical-location/20220301-030738
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: arm-randconfig-c002-20220228 (https://download.01.org/0day-ci/archive/20220301/202203010527.LaNAQMXX-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/93d7a0fa1ed009ae6cc98fe5039cec8c9c77609f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Won-Chung/usb-typec-Add-sysfs-support-for-Type-C-connector-s-physical-location/20220301-030738
git checkout 93d7a0fa1ed009ae6cc98fe5039cec8c9c77609f
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash drivers/usb/typec/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> drivers/usb/typec/class.c:1649:7: warning: no previous prototype for 'get_pld' [-Wmissing-prototypes]
1649 | void *get_pld(struct device *dev)
| ^~~~~~~
vim +/get_pld +1649 drivers/usb/typec/class.c
1648
> 1649 void *get_pld(struct device *dev)
1650 {
1651 #ifdef CONFIG_ACPI
1652 struct acpi_pld_info *pld;
1653 acpi_status status;
1654
1655 if (!has_acpi_companion(dev))
1656 return NULL;
1657
1658 status = acpi_get_physical_device_location(ACPI_HANDLE(dev), &pld);
1659 if (ACPI_FAILURE(status))
1660 return NULL;
1661 return pld;
1662 #else
1663 return NULL;
1664 #endif
1665 }
1666
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists