linux-kernel - Re: [PATCH] crypto: drbg: fix crypto api abuse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOtvUMdX2N9XcBV81rSKz=orZ-3XHWW8ChXnuKAeiAsQy5P_Vg@mail.gmail.com>
Date:   Mon, 28 Feb 2022 11:09:05 +0200
From:   Gilad Ben-Yossef <gilad@...yossef.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Ofir Drang <ofir.drang@....com>,
        Corentin Labbe <clabbe.montjoie@...il.com>,
        stable <stable@...r.kernel.org>,
        Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: drbg: fix crypto api abuse

Hi,

On Sun, Feb 27, 2022 at 12:12 PM Gilad Ben-Yossef <gilad@...yossef.com> wrote:
...


>
> I think the right thing to do right now is to verify that we indeed
> have a general issue and not something specific to one singular
> platform
> So the question becomes - do indeed the DMA api forbits aliased
> mappings and if so, under what conditions?
>
> Any ideas on how to check this?

OK, I've looked into this further and I think I was wrong.
The DMA api doesn't like overlapping writable mappings, but it seems
an overlapping read-only and writable mapping are fine.
If so I can indeed resolve this in the driver code by better
specifying DMA direction. Let me give this a go and let's drop this
patch in the meantime.

Thank you and sorry for the noise.

Gilad

-- 
Gilad Ben-Yossef
Chief Coffee Drinker

values of β will give rise to dom!