linux-kernel - Re: [PATCH AUTOSEL 5.10 04/23] usb: usb251xb: add boost-up property support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yhy+pvprwSx4zdCG@ltleri2>
Date:   Mon, 28 Feb 2022 13:23:02 +0100
From:   Richard Leitner <richard.leitner@...ux.dev>
To:     Pavel Machek <pavel@...x.de>
Cc:     Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org, Tommaso Merciai <tomm.merciai@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        richard.leitner@...data.com, linux-usb@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.10 04/23] usb: usb251xb: add boost-up property
 support

Hi,

On Sun, Feb 20, 2022 at 11:12:57AM +0100, Pavel Machek wrote:
> Hi!
> 
> > From: Tommaso Merciai <tomm.merciai@...il.com>
> > 
> > [ Upstream commit 5c2b9c61ae5d8ad0a196d33b66ce44543be22281 ]
> > 
> > Add support for boost-up register of usb251xb hub.
> > boost-up property control USB electrical drive strength
> > This register can be set:
> > 
> >  - Normal mode -> 0x00
> >  - Low         -> 0x01
> >  - Medium      -> 0x10
> >  - High        -> 0x11
> > 
> > (Normal Default)
> > 
> > References:
> >  - http://www.mouser.com/catalog/specsheets/2514.pdf p29
> 
> Should the boost-up property be documented somewhere in the kernel
> tree? We normally do that for device tree properties. And we normally
> have properties used somewhere in the device tree. What is going on here?

AFAIK this patch was dropped for all stable releases, so this specific
AUTOSEL message/thread is obsolete.

Nonetheless the DT documentation is also missing on master. Therefore
I guess it should be provided asap 😉

Tommaso, can you provide a patch?

regards;rl

> 
> Best regards,
> 							Pavel