linux-kernel - Re: [PATCH V7 4/5] arm64: dts: qcom: pm8008: Add base dts file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c91d3226-d407-f574-f776-d29be08c892e@quicinc.com>
Date:   Mon, 28 Feb 2022 19:48:51 +0530
From:   "Satya Priya Kakitapalli (Temp)" <quic_c_skakit@...cinc.com>
To:     Stephen Boyd <swboyd@...omium.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>
CC:     Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Das Srinagesh <gurus@...eaurora.org>,
        <linux-arm-msm@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_collinsd@...cinc.com>,
        <quic_subbaram@...cinc.com>, <quic_jprakash@...cinc.com>
Subject: Re: [PATCH V7 4/5] arm64: dts: qcom: pm8008: Add base dts file


On 2/19/2022 7:27 AM, Stephen Boyd wrote:
> Quoting Satya Priya (2022-02-18 03:01:02)
>> Add base DTS file for pm8008 with infra and regulator nodes.
>>
>> Signed-off-by: Satya Priya <quic_c_skakit@...cinc.com>
>> ---
>> Changes in V4:
>>   - This is newly added in V4, to add all the pm8008 common stuff.
>>
>> Changes in V5:
>>   - Changed the mfd node names from pm8008_chip to pm8008_infra and
>>     pm8008_ldo to pm8008_regulators as they re more appropriate.
>>   - Changed the compatible for pm8008@9 mfd node to differentiate from
>>     pm8008@8 node in driver.
>>   - Removed compatible for regulators node.
>>   - Removed reg property for LDOs and added in driver.
>>
>> Changes in V6:
>>   - Changed node names to small letters.
>>
>> Changes in V7:
>>   - Removed intermediate regulators node.
>>
>>   arch/arm64/boot/dts/qcom/pm8008.dtsi | 44 ++++++++++++++++++++++++++++++++++++
>>   1 file changed, 44 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/qcom/pm8008.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm8008.dtsi b/arch/arm64/boot/dts/qcom/pm8008.dtsi
>> new file mode 100644
>> index 0000000..0f48572
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/pm8008.dtsi
>> @@ -0,0 +1,44 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +// Copyright (c) 2022, The Linux Foundation. All rights reserved.
>> +
>> +pm8008_infra: pm8008@8 {
> Node name should be generic, pmic@8


Okay.


>> +       compatible = "qcom,pm8008";
>> +       reg = <0x8>;
>> +       #address-cells = <1>;
>> +       #size-cells = <0>;
>> +};
>> +
>> +pm8008_regulators: pm8008@9 {
> Node name should be generic, pmic@9


Okay.


>> +       compatible = "qcom,pm8008-regulators";
>> +       reg = <0x9>;
>> +       #address-cells = <1>;
> Address cells is 0 too?


Okay.


>> +       #size-cells = <0>;
>> +
>> +       pm8008_l1: ldo1 {
>> +               regulator-name = "pm8008_l1";
>> +       };
>> +
>> +       pm8008_l2: ldo2 {
>> +               regulator-name = "pm8008_l2";
>> +       };
>> +
>> +       pm8008_l3: ldo3 {
>> +               regulator-name = "pm8008_l3";
>> +       };
>> +
>> +       pm8008_l4: ldo4 {
>> +               regulator-name = "pm8008_l4";
>> +       };
>> +
>> +       pm8008_l5: ldo5 {
>> +               regulator-name = "pm8008_l5";
>> +       };
>> +
>> +       pm8008_l6: ldo6 {
>> +               regulator-name = "pm8008_l6";
>> +       };
>> +
>> +       pm8008_l7: ldo7 {
>> +               regulator-name = "pm8008_l7";
>> +       };
>>