linux-kernel - Re: [PATCH 3/3] dt-bindings: spi: Add spiclk to clock-names property in pl022

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f22e9ddc-3103-2785-5504-fcc95d08cc8b@arm.com>
Date:   Mon, 28 Feb 2022 14:36:23 +0000
From:   Robin Murphy <robin.murphy@....com>
To:     Kuldeep Singh <singh.kuldeep87k@...il.com>,
        Mark Brown <broonie@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-spi@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH 3/3] dt-bindings: spi: Add spiclk to clock-names property
 in pl022

On 2022-02-28 12:43, Kuldeep Singh wrote:
> Fix below dtc warning by making necessary addition of "spiclk" in
> clock-names property.
> 
> arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dt.yaml: spi@...000:
> clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk']
>      From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml
> arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dt.yaml: spi@...90000:
> clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk']
>      From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml

As before, what makes the binding at fault rather than that DT? The 
PL022's actual input is named SSPCLK, not SPICLK, so why should a driver 
which wants to look up that clock by name expect to look for "spiclk"?

Robin.

> Signed-off-by: Kuldeep Singh <singh.kuldeep87k@...il.com>
> ---
>   Documentation/devicetree/bindings/spi/spi-pl022.yaml | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-pl022.yaml b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> index 5f6926a58b15..fb3075a0c7fd 100644
> --- a/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-pl022.yaml
> @@ -45,6 +45,7 @@ properties:
>             - enum:
>                 - sspclk
>                 - SSPCLK
> +              - spiclk
>             - const: apb_pclk
>   
>     pl022,autosuspend-delay: