linux-kernel - Re: [PATCH] arm64: dts: qcom: sm8150: Add ufs power-domain entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH=2NtxNj=hYPV0cQUN-8Gwm92Mj8tOdN1iDKg8skd=5NzvFVg@mail.gmail.com>
Date:   Mon, 28 Feb 2022 20:13:50 +0530
From:   Bhupesh Sharma <bhupesh.sharma@...aro.org>
To:     Alexey Minnekhanov <alexeymin@...tmarketos.org>
Cc:     linux-arm-msm@...r.kernel.org, bhupesh.linux@...il.com,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        robh+dt@...nel.org, bjorn.andersson@...aro.org, agross@...nel.org,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sm8150: Add ufs power-domain entries

Hi Alexey,

On Fri, 28 Jan 2022 at 19:37, Alexey Minnekhanov
<alexeymin@...tmarketos.org> wrote:
>
> At 20.01.2022 11:28, Bhupesh Sharma wrote:
> > Add power-domain entries for UFS controller & phy nodes
> > in sm8150 dts.
> >
> > ...
> > +                     power-domains = <&gcc UFS_PHY_GDSC>;
> >                       resets = <&gcc GCC_UFS_PHY_BCR>;
> >                       reset-names = "rst";
> > ...
> > +                     power-domains = <&gcc UFS_CARD_GDSC>,
> > +                                     <&gcc UFS_PHY_GDSC>;
> > +                     power-domain-names = "ufs_card_gdsc", "ufs_phy_gdsc";
>
> Strange, but I don't see neither UFS_PHY_GDSC nor UFS_CARD_GDSC in
> gcc-sm8150.c [1] (and accordingly not in
> include/dt-bindings/clock/qcom,gcc-sm8150.h), but they are present in
> corresponding files for sm8250 [2].
>
> By quick look at downstream sm8150-gdsc.dtsi addresses seem to be
> similar to one used on sm8250, so I'm guessing gcc-sm8150 has to be
> fixed first for this patch to work?

You are right.
I am sending a v2 shortly, which fixes this issue.

Regards,
Bhupesh