linux-kernel - [PATCH V5 2/5] dt-bindings: mailbox: imx-mu: add i.MX93 S4 MU support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220228024013.2866386-3-peng.fan@oss.nxp.com>
Date:   Mon, 28 Feb 2022 10:40:10 +0800
From:   "Peng Fan (OSS)" <peng.fan@....nxp.com>
To:     jassisinghbrar@...il.com, robh+dt@...nel.org, shawnguo@...nel.org
Cc:     s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        krzysztof.kozlowski@...onical.com, daniel.baluta@....com,
        Peng Fan <peng.fan@....com>
Subject: [PATCH V5 2/5] dt-bindings: mailbox: imx-mu: add i.MX93 S4 MU support

From: Peng Fan <peng.fan@....com>

Similar to i.MX8ULP S4 MU, i.MX93 MU is dedicated for communication
between Sentinel and Cortex-A cores from hardware design, it could not be
reused for other purpose.

However i.MX93 S4 MU use separate tx/rx interrupt, so update
interrupts and add interrupt-names property.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Signed-off-by: Peng Fan <peng.fan@....com>
---


Hi Rob,
 For dual entries, I tested below with dt_binding_check and dtbs_check
 "
 +		s4muap: s4muap@...20000 {
 +			compatible = "fsl,imx93-mu-s4";
 +			reg = <0x47520000 0x10000>;
 +			interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
 +			interrupt-names = "tx", "rx";
 +			#mbox-cells = <2>;
 +			status = "okay";
 +		};
 +
 +		s4muap1: s4muap@...20000 {
 +			compatible = "fsl,imx8ulp-mu-s4";
 +			reg = <0x48520000 0x10000>;
 +			interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
 +			interrupt-names = "tx", "rx";
 +			#mbox-cells = <2>;
 +			status = "okay";
 +		};
 "

 .../devicetree/bindings/mailbox/fsl,mu.yaml   | 28 ++++++++++++++++++-
 1 file changed, 27 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
index 6d056d5e16bf..82ce0280add9 100644
--- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
+++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
@@ -29,6 +29,7 @@ properties:
       - const: fsl,imx8ulp-mu
       - const: fsl,imx8-mu-scu
       - const: fsl,imx8-mu-seco
+      - const: fsl,imx93-mu-s4
       - const: fsl,imx8ulp-mu-s4
       - items:
           - const: fsl,imx93-mu
@@ -55,7 +56,14 @@ properties:
     maxItems: 1
 
   interrupts:
-    maxItems: 1
+    minItems: 1
+    maxItems: 2
+
+  interrupt-names:
+    minItems: 1
+    items:
+      - const: tx
+      - const: rx
 
   "#mbox-cells":
     description: |
@@ -90,6 +98,24 @@ required:
   - interrupts
   - "#mbox-cells"
 
+allOf:
+  - if:
+      properties:
+        compatible:
+          enum:
+            - fsl,imx93-mu-s4
+    then:
+      properties:
+        interrupt-names:
+          minItems: 2
+        interrupts:
+          minItems: 2
+
+    else:
+      properties:
+        interrupts:
+          maxItems: 1
+
 additionalProperties: false
 
 examples:
-- 
2.25.1