linux-kernel - Re: [PATCH] SoC: polarfire: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b8eb2e55-b5a8-4a39-86cb-93cadbd67922@conchuod.ie>
Date:   Mon, 28 Feb 2022 15:35:03 +0000
From:   Conor Dooley <mail@...chuod.ie>
To:     Arnd Bergmann <arnd@...nel.org>,
        Lewis Hanly <lewis.hanly@...rochip.com>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Conor Dooley <conor.dooley@...rochip.com>
Cc:     Arnd Bergmann <arnd@...db.de>, kernel test robot <lkp@...el.com>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] SoC: polarfire: fix build warning

I had sent a fix for the build warning on saturday morning - but I guess 
you missed it.

Thanks for fixing it anyway :)
Conor.

On 28/02/2022 15:26, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The newly added driver causes a build warning because of a missing
> prototype:
> 
> drivers/soc/microchip/mpfs-sys-controller.c:76:6: warning: no previous prototype for function 'mpfs_sys_controller_put' [-Wmissing-prototypes]
> 
> Link: https://lore.kernel.org/llvm/202202260947.F5T1YNao-lkp@intel.com/
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: d0054a470c33 ("soc: add microchip polarfire soc system controller")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> I've applied this to the arm/drivers branch as a fixup
> 
>   include/soc/microchip/mpfs.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/include/soc/microchip/mpfs.h b/include/soc/microchip/mpfs.h
> index 6466515262bd..969b5239521e 100644
> --- a/include/soc/microchip/mpfs.h
> +++ b/include/soc/microchip/mpfs.h
> @@ -38,6 +38,8 @@ int mpfs_blocking_transaction(struct mpfs_sys_controller *mpfs_client, struct mp
>   
>   struct mpfs_sys_controller *mpfs_sys_controller_get(struct device *dev);
>   
> +void mpfs_sys_controller_put(void *data);
> +
>   #endif /* if IS_ENABLED(CONFIG_POLARFIRE_SOC_SYS_CTRL) */
>   
>   #endif /* __SOC_MPFS_H__ */