linux-kernel - [ammarfaizi2-block:netdev/net-next/master 81/85] drivers/net/hamradio/dmascc.c:1357:83: error: expected ')' before '{' token

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202203010813.uYqLFxOY-lkp@intel.com>
Date:   Tue, 1 Mar 2022 08:24:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     Wang Qing <wangqing@...o.com>
Cc:     kbuild-all@...ts.01.org,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org
Subject: [ammarfaizi2-block:netdev/net-next/master 81/85]
 drivers/net/hamradio/dmascc.c:1357:83: error: expected ')' before '{' token

tree:   https://github.com/ammarfaizi2/linux-block netdev/net-next/master
head:   0b9e69e1a1e4d60473486d15217845ae1e151d4a
commit: 61c4fb9c4d09dfb6f33690169560862d5d0e42f7 [81/85] net: hamradio: use time_is_after_jiffies() instead of open coding it
config: alpha-buildonly-randconfig-r005-20220227 (https://download.01.org/0day-ci/archive/20220301/202203010813.uYqLFxOY-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/ammarfaizi2/linux-block/commit/61c4fb9c4d09dfb6f33690169560862d5d0e42f7
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block netdev/net-next/master
        git checkout 61c4fb9c4d09dfb6f33690169560862d5d0e42f7
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=alpha SHELL=/bin/bash drivers/net/hamradio/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/net/hamradio/dmascc.c: In function 'es_isr':
>> drivers/net/hamradio/dmascc.c:1357:83: error: expected ')' before '{' token
    1357 |                     time_is_after_jiffies(priv->tx_start + priv->param.txtimeout) {
         |                                                                                   ^
   drivers/net/hamradio/dmascc.c:1356:20: note: to match this '('
    1356 |                 if (priv->tx_count &&
         |                    ^
>> drivers/net/hamradio/dmascc.c:1364:9: error: expected expression before '}' token
    1364 |         }
         |         ^


vim +1357 drivers/net/hamradio/dmascc.c

  1305	
  1306	
  1307	static void es_isr(struct scc_priv *priv)
  1308	{
  1309		int i, rr0, drr0, res;
  1310		unsigned long flags;
  1311	
  1312		/* Read status, reset interrupt bit (open latches) */
  1313		rr0 = read_scc(priv, R0);
  1314		write_scc(priv, R0, RES_EXT_INT);
  1315		drr0 = priv->rr0 ^ rr0;
  1316		priv->rr0 = rr0;
  1317	
  1318		/* Transmit underrun (2.4.9.6). We can't check the TxEOM flag, since
  1319		   it might have already been cleared again by AUTOEOM. */
  1320		if (priv->state == TX_DATA) {
  1321			/* Get remaining bytes */
  1322			i = priv->tx_tail;
  1323			if (priv->param.dma >= 0) {
  1324				disable_dma(priv->param.dma);
  1325				flags = claim_dma_lock();
  1326				res = get_dma_residue(priv->param.dma);
  1327				release_dma_lock(flags);
  1328			} else {
  1329				res = priv->tx_len[i] - priv->tx_ptr;
  1330				priv->tx_ptr = 0;
  1331			}
  1332			/* Disable DREQ / TX interrupt */
  1333			if (priv->param.dma >= 0 && priv->type == TYPE_TWIN)
  1334				outb(0, priv->card_base + TWIN_DMA_CFG);
  1335			else
  1336				write_scc(priv, R1, EXT_INT_ENAB | WT_FN_RDYFN);
  1337			if (res) {
  1338				/* Update packet statistics */
  1339				priv->dev->stats.tx_errors++;
  1340				priv->dev->stats.tx_fifo_errors++;
  1341				/* Other underrun interrupts may already be waiting */
  1342				write_scc(priv, R0, RES_EXT_INT);
  1343				write_scc(priv, R0, RES_EXT_INT);
  1344			} else {
  1345				/* Update packet statistics */
  1346				priv->dev->stats.tx_packets++;
  1347				priv->dev->stats.tx_bytes += priv->tx_len[i];
  1348				/* Remove frame from FIFO */
  1349				priv->tx_tail = (i + 1) % NUM_TX_BUF;
  1350				priv->tx_count--;
  1351				/* Inform upper layers */
  1352				netif_wake_queue(priv->dev);
  1353			}
  1354			/* Switch state */
  1355			write_scc(priv, R15, 0);
  1356			if (priv->tx_count &&
> 1357			    time_is_after_jiffies(priv->tx_start + priv->param.txtimeout) {
  1358				priv->state = TX_PAUSE;
  1359				start_timer(priv, priv->param.txpause, 0);
  1360			} else {
  1361				priv->state = TX_TAIL;
  1362				start_timer(priv, priv->param.txtail, 0);
  1363			}
> 1364		}
  1365	
  1366		/* DCD transition */
  1367		if (drr0 & DCD) {
  1368			if (rr0 & DCD) {
  1369				switch (priv->state) {
  1370				case IDLE:
  1371				case WAIT:
  1372					priv->state = DCD_ON;
  1373					write_scc(priv, R15, 0);
  1374					start_timer(priv, priv->param.dcdon, 0);
  1375				}
  1376			} else {
  1377				switch (priv->state) {
  1378				case RX_ON:
  1379					rx_off(priv);
  1380					priv->state = DCD_OFF;
  1381					write_scc(priv, R15, 0);
  1382					start_timer(priv, priv->param.dcdoff, 0);
  1383				}
  1384			}
  1385		}
  1386	
  1387		/* CTS transition */
  1388		if ((drr0 & CTS) && (~rr0 & CTS) && priv->type != TYPE_TWIN)
  1389			tm_isr(priv);
  1390	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org