linux-kernel - Re: [PATCH 2/4] KVM: x86: SVM: disable preemption in avic_refresh_apicv_exec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c6f4d7e5-6138-084e-067f-6bb1ecda9e2c@redhat.com>
Date:   Tue, 1 Mar 2022 18:23:18 +0100
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Maxim Levitsky <mlevitsk@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>
Cc:     kvm@...r.kernel.org, Jim Mattson <jmattson@...gle.com>,
        "H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Borislav Petkov <bp@...en8.de>, x86@...nel.org
Subject: Re: [PATCH 2/4] KVM: x86: SVM: disable preemption in
 avic_refresh_apicv_exec_ctrl

On 3/1/22 18:20, Maxim Levitsky wrote:
> I don't see that this patch is much different that what I proposed,
> especially since disable of preemption can be nested.

The difference is that it's done in avic_vcpu_{load,put} instead of the 
caller.  I like that your patch is smaller, but I like that Sean's patch 
solves it for good.

I queued his, but maybe I could apply yours to 5.17 and his to 5.18.  I 
might do this if I have to send more stuff to Linus before the release.

Paolo