linux-kernel - Re: [PATCH 0/4] x86/acpi/cppc: Minor clean up for x86 CPPC implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jgqzzog_F+DtgKk544FDQ=iQ_rDfwKeHnEiLLrCyi9Hw@mail.gmail.com>
Date:   Tue, 1 Mar 2022 20:20:45 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Huang Rui <ray.huang@....com>
Cc:     Borislav Petkov <bp@...en8.de>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Giovanni Gherdovich <ggherdovich@...e.cz>,
        Alex Deucher <alexander.deucher@....com>,
        Deepak Sharma <deepak.sharma@....com>,
        Jinzhou Su <Jinzhou.Su@....com>,
        Perry Yuan <Perry.Yuan@....com>,
        Jassmine Meng <li.meng@....com>
Subject: Re: [PATCH 0/4] x86/acpi/cppc: Minor clean up for x86 CPPC implementation

On Mon, Feb 14, 2022 at 11:51 AM Huang Rui <ray.huang@....com> wrote:
>
> Hi all,
>
> While we were fixing the legacy issue below, we found the dependencies
> between smpboot and CPPC were not very good. But due to urgent fix for
> 5.17-rc1, I didn't have much time to provide a complete solution.
>
> https://lore.kernel.org/lkml/YdeWDDCwBQAYnlKb@amd.com/
>
> In these series, I expand the scope of acpi/cppc_msr to acpi/cppc to cover
> the all the CPPC helper functions for x86 ACPI. And then clean up the
> smpboot and move CPPC related functions into the acpi/cppc.c. This design
> is more straightforward and more clear to handle the CPPC in x86 and
> resolve dependency issues between CPPC and smpboot.c.
>
> Thanks,
> Ray
>
> Huang Rui (4):
>   x86/acpi: Expand the CPPC MSR file to cover the whole CPPC
>     implementation
>   x86, sched: Move AMD maximum frequency ratio setting function into x86
>     CPPC
>   x86, sched: Expose init_freq_invariance to topology header
>   x86/acpi: Move init_freq_invariance_cppc into x86 CPPC
>
>  arch/x86/include/asm/topology.h |  13 +++-
>  arch/x86/kernel/acpi/Makefile   |   2 +-
>  arch/x86/kernel/acpi/cppc.c     | 103 ++++++++++++++++++++++++++++++++
>  arch/x86/kernel/acpi/cppc_msr.c |  49 ---------------
>  arch/x86/kernel/smpboot.c       |  72 +---------------------
>  5 files changed, 118 insertions(+), 121 deletions(-)
>  create mode 100644 arch/x86/kernel/acpi/cppc.c
>  delete mode 100644 arch/x86/kernel/acpi/cppc_msr.c
>
> --

This series makes sense to me and I'm inclined to take it if there are
no objections, so if there are any, please let me know.