linux-kernel - Re: [PATCH] sched: Make preempt_enable_no_resched() behave like preempt_enable() on PREEMPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yh6A1a6yBfPW8AMk@linutronix.de>
Date:   Tue, 1 Mar 2022 21:23:49 +0100
From:   Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org, Ben Segall <bsegall@...gle.com>,
        Daniel Bristot de Oliveira <bristot@...hat.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Ingo Molnar <mingo@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Mel Gorman <mgorman@...e.de>,
        Steven Rostedt <rostedt@...dmis.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH] sched: Make preempt_enable_no_resched() behave like
 preempt_enable() on PREEMPT_RT

On 2022-03-01 21:14:32 [+0100], Peter Zijlstra wrote:
> Ignoring !x86 for a moment:
> 
> arch/x86/mm/kmmio.c:    preempt_enable_no_resched();
> arch/x86/mm/kmmio.c:    preempt_enable_no_resched();
> include/linux/preempt.h:#define sched_preempt_enable_no_resched() \
> include/linux/preempt.h:#define preempt_enable_no_resched() sched_preempt_enable_no_resched()
> include/linux/preempt.h:#define preempt_enable_no_resched_notrace() \
> include/linux/preempt.h:#define sched_preempt_enable_no_resched()       barrier()
> include/linux/preempt.h:#define preempt_enable_no_resched()             barrier()
> include/linux/preempt.h:#define preempt_enable_no_resched_notrace()     barrier()
> include/linux/preempt.h:#undef sched_preempt_enable_no_resched
> include/linux/preempt.h:#undef preempt_enable_no_resched
> include/linux/preempt.h:#undef preempt_enable_no_resched_notrace
> kernel/sched/core.c:            preempt_enable_no_resched();
> kernel/sched/core.c:                    preempt_enable_no_resched();
> kernel/sched/core.c:            sched_preempt_enable_no_resched();
> kernel/sched/core.c:    sched_preempt_enable_no_resched();
> kernel/sched/core.c:            sched_preempt_enable_no_resched();
> kernel/sched/core.c:            preempt_enable_no_resched_notrace();
> kernel/sched/core.c:            preempt_enable_no_resched_notrace();
> kernel/sched/core.c:            sched_preempt_enable_no_resched();
> kernel/sched/core.c:    sched_preempt_enable_no_resched();
> kernel/signal.c:                preempt_enable_no_resched();
> kernel/smpboot.c:                       preempt_enable_no_resched();
> lib/smp_processor_id.c: preempt_enable_no_resched_notrace();
> 
> 
> Surely we can audit that... At a glance the proposed patch does more
> harm than good. Only the kmmio case looks obviousl fail, but then IIRC
> kmmio had worse problems.

I was looking at the same before posting it. The majority of it
disappeared over time after certain someone made it worthless for
modules. So I'm dropping it then.
Does it make sense to keep sched_preempt_enable_no_resched() or should I
move everything to preempt_enable_no_resched()?

Sebastian