linux-kernel - Re: [PATCH v2 2/2] ARM: dts: kirkwood: Add Ctera C-200 V1 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJN1KkygDrGPzJj4nobS-ZFSRqP+g9LQ49tbcLA8V7KvPhfYOQ@mail.gmail.com>
Date:   Tue, 1 Mar 2022 21:32:27 +0100
From:   Paweł Dembicki <paweldembicki@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Rob Herring <robh+dt@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Olof Johansson <olof@...om.net>, soc@...nel.org,
        Andrew Lunn <andrew@...n.ch>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sam Ravnborg <sam@...nborg.org>,
        Corentin Labbe <clabbe@...libre.com>,
        Oleksij Rempel <linux@...pel-privat.de>,
        Hao Fang <fanghao11@...wei.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, linux-kernel@...r.kernel.org,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/2] ARM: dts: kirkwood: Add Ctera C-200 V1 board

wt., 1 mar 2022 o 00:43 Linus Walleij <linus.walleij@...aro.org> napisał(a):
>
> On Tue, Feb 15, 2022 at 5:40 PM Pawel Dembicki <paweldembicki@...il.com> wrote:
>
> > +&i2c0 {
> > +       status = "okay";
> > +
> > +       rtc@30 {
> > +               compatible = "s35390a";
> > +               reg = <0x30>;
> > +       };
> > +
> > +       lm63@4c {
> > +               compatible = "national,lm63";
> > +               reg = <0x4c>;
> > +       };
>
> Think about adding chassis thermal zone for this sensor,
>
> I suppose you don't have any active control of cooling (fan)?
> This often sits on GPIO...
>

Hi Linus,
It has a fan controlled by the lm63: PWM controller. But the fan blows
only on disks, board temperature won't change even when PWM = 100%.
It should be controlled by hdd temperature.

> In that case just add a critical temperature so it can't burn
> down the house.
>

Patch it's merged now, I will add critical temperatures in a separate patch.

> See:
> arch/arm/boot/dts/gemini-dlink-dns-313.dts
> node thermal-zones {} for an example of how to do this
> quick and easy. You need CONFIG_THERMAL and
> CONFIG_THERMAL_HWMON for this to work.
>
> Yours,
> Linus Walleij

Best Regards,
Pawel Dembicki