linux-kernel - Re: [PATCH] i2c: busses: i2c-mt65xx: Simplify with clk-bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yh6T3RSfvcXCi4sb@ninjato>
Date:   Tue, 1 Mar 2022 22:45:01 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     qii.wang@...iatek.com, matthias.bgg@...il.com,
        linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH] i2c: busses: i2c-mt65xx: Simplify with clk-bulk

On Mon, Feb 14, 2022 at 12:26:30PM +0100, AngeloGioacchino Del Regno wrote:
> Il 18/01/22 14:33, AngeloGioacchino Del Regno ha scritto:
> > Since depending on the SoC or specific bus functionality some clocks
> > may be optional, we cannot get the benefit of using devm_clk_bulk_get()
> > but, by migrating to clk-bulk, we are able to remove the custom functions
> > mtk_i2c_clock_enable() and mtk_i2c_clock_disable(), increasing common
> > APIs usage, hence (lightly) decreasing kernel footprint.
> > 
> > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> > ---
> >   drivers/i2c/busses/i2c-mt65xx.c | 127 +++++++++++++-------------------
> >   1 file changed, 51 insertions(+), 76 deletions(-)
> > 
> 
> Hello,
> this is a friendly ping to request review on this patch as to avoid forgetting it.
> 
> Adding context, I have tested this patch on multiple (older/newer) MediaTek
> platforms.

Qii Wang, what do you think about this patch?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)