linux-kernel - Re: [PATCH v2 6/8] arm64: dts: qcom: ipq6018: Fix qmp usb3 phy node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220301041147.GI269879@dragon>
Date:   Tue, 1 Mar 2022 12:11:47 +0800
From:   Shawn Guo <shawn.guo@...aro.org>
To:     Bhupesh Sharma <bhupesh.sharma@...aro.org>
Cc:     linux-arm-msm@...r.kernel.org, bhupesh.linux@...il.com,
        agross@...nel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, vkoul@...nel.org,
        linux-phy@...ts.infradead.org, robh+dt@...nel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v2 6/8] arm64: dts: qcom: ipq6018: Fix qmp usb3 phy node

On Mon, Feb 28, 2022 at 06:00:17PM +0530, Bhupesh Sharma wrote:
> Fix the following 'make dtbs_check' warning(s) by
> using phy@ instead of lanes@ and by moving '#clock-names' to

s/clock-names/clock-cells

> sub-node:
> 
> arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dt.yaml: ssphy@...00:
>  'lane@...00' does not match any of the regexes: '^phy@[0-9a-f]+$', 'pinctrl-[0-9]+'
> 
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Cc: Rob Herring <robh@...nel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@...aro.org>

Other than that:

Reviewed-by: Shawn Guo <shawn.guo@...aro.org>

> ---
>  arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> index 66ec5615651d..ad7914e49532 100644
> --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
> @@ -674,7 +674,6 @@ ssphy_0: ssphy@...00 {
>  			reg = <0x0 0x78000 0x0 0x1C4>;
>  			#address-cells = <2>;
>  			#size-cells = <2>;
> -			#clock-cells = <1>;
>  			ranges;
>  
>  			clocks = <&gcc GCC_USB0_AUX_CLK>,
> @@ -686,12 +685,13 @@ ssphy_0: ssphy@...00 {
>  			reset-names = "phy","common";
>  			status = "disabled";
>  
> -			usb0_ssphy: lane@...00 {
> +			usb0_ssphy: phy@...00 {
>  				reg = <0x0 0x00078200 0x0 0x130>, /* Tx */
>  				      <0x0 0x00078400 0x0 0x200>, /* Rx */
>  				      <0x0 0x00078800 0x0 0x1F8>, /* PCS */
>  				      <0x0 0x00078600 0x0 0x044>; /* PCS misc */
>  				#phy-cells = <0>;
> +				#clock-cells = <1>;
>  				clocks = <&gcc GCC_USB0_PIPE_CLK>;
>  				clock-names = "pipe0";
>  				clock-output-names = "gcc_usb0_pipe_clk_src";
> -- 
> 2.35.1
>