lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202203010741.SK3KjyE8-lkp@intel.com>
Date:   Tue, 1 Mar 2022 08:04:12 +0800
From:   kernel test robot <lkp@...el.com>
To:     Amir Goldstein <amir73il@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [amir73il:sb_iostats 6/8] fs/proc_namespace.c:243:9: error: 'struct
 super_block' has no member named 's_iostats'

tree:   https://github.com/amir73il/linux sb_iostats
head:   ecfdb413f2105083296e9cb45290eb1f01b0ef5c
commit: df9b63258be710a78278da75d11cfe0cbaa8ca74 [6/8] fs: report per-sb io stats
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220301/202203010741.SK3KjyE8-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/amir73il/linux/commit/df9b63258be710a78278da75d11cfe0cbaa8ca74
        git remote add amir73il https://github.com/amir73il/linux
        git fetch --no-tags amir73il sb_iostats
        git checkout df9b63258be710a78278da75d11cfe0cbaa8ca74
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   fs/proc_namespace.c: In function 'show_vfsstat':
>> fs/proc_namespace.c:243:9: error: 'struct super_block' has no member named 's_iostats'
     243 |       sb->s_iostats.start_time, ktime_get_seconds(),
         |         ^~


vim +243 fs/proc_namespace.c

   196	
   197	static int show_vfsstat(struct seq_file *m, struct vfsmount *mnt)
   198	{
   199		struct proc_mounts *p = m->private;
   200		struct mount *r = real_mount(mnt);
   201		struct path mnt_path = { .dentry = mnt->mnt_root, .mnt = mnt };
   202		struct super_block *sb = mnt_path.dentry->d_sb;
   203		int err;
   204	
   205		/* device */
   206		if (sb->s_op->show_devname) {
   207			seq_puts(m, "device ");
   208			err = sb->s_op->show_devname(m, mnt_path.dentry);
   209			if (err)
   210				goto out;
   211		} else {
   212			if (r->mnt_devname) {
   213				seq_puts(m, "device ");
   214				mangle(m, r->mnt_devname);
   215			} else
   216				seq_puts(m, "no device");
   217		}
   218	
   219		/* mount point */
   220		seq_puts(m, " mounted on ");
   221		/* mountpoints outside of chroot jail will give SEQ_SKIP on this */
   222		err = seq_path_root(m, &mnt_path, &p->root, " \t\n\\");
   223		if (err)
   224			goto out;
   225		seq_putc(m, ' ');
   226	
   227		/* file system type */
   228		seq_puts(m, "with fstype ");
   229		show_type(m, sb);
   230	
   231		/* optional statistics */
   232		if (sb->s_op->show_stats) {
   233			seq_putc(m, ' ');
   234			err = sb->s_op->show_stats(m, mnt_path.dentry);
   235		} else if (sb_has_iostats(sb)) {
   236			/* Similar to /proc/<pid>/io */
   237			seq_printf(m, "\n"
   238				   "\ttimes: %lld %lld\n"
   239				   "\trchar: %lld\n"
   240				   "\twchar: %lld\n"
   241				   "\tsyscr: %lld\n"
   242				   "\tsyscw: %lld\n",
 > 243				   sb->s_iostats.start_time, ktime_get_seconds(),
   244				   sb_iostats_counter_read(sb, SB_IOSTATS_CHARS_RD),
   245				   sb_iostats_counter_read(sb, SB_IOSTATS_CHARS_WR),
   246				   sb_iostats_counter_read(sb, SB_IOSTATS_SYSCALLS_RD),
   247				   sb_iostats_counter_read(sb, SB_IOSTATS_SYSCALLS_WR));
   248		}
   249	
   250		seq_putc(m, '\n');
   251	out:
   252		return err;
   253	}
   254	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ