linux-kernel - Re: [PATCH] driver core: dd: fix return value of _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 1 Mar 2022 14:27:56 +0800
From:   Feng Tang <feng.tang@...el.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
        Igor Zhbanov <i.zhbanov@...russia.ru>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH] driver core: dd: fix return value of __setup handler

Hi Randy,

On Mon, Feb 28, 2022 at 08:18:29PM -0800, Randy Dunlap wrote:
> When "driver_async_probe=nulltty" is used on the kernel boot command line,
> it causes an Unknown parameter message and the string is added to init's
> environment strings, polluting them.
> 
>   Unknown kernel command line parameters "BOOT_IMAGE=/boot/bzImage-517rc6
>   driver_async_probe=nulltty", will be passed to user space.
> 
>  Run /sbin/init as init process
>    with arguments:
>      /sbin/init
>    with environment:
>      HOME=/
>      TERM=linux
>      BOOT_IMAGE=/boot/bzImage-517rc6
>      driver_async_probe=nulltty
> 
> Change the return value of the __setup function to 1 to indicate
> that the __setup option has been handled.

Thanks for the fix!

Reviewed-by: Feng Tang <feng.tang@...el.com>


> Fixes: 1ea61b68d0f8 ("async: Add cmdline option to specify drivers to be async probed")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Reported-by: Igor Zhbanov <i.zhbanov@...russia.ru>
> Link: lore.kernel.org/r/64644a2f-4a20-bab3-1e15-3b2cdd0defe3@...russia.ru
> Cc: Feng Tang <feng.tang@...el.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> ---
>  drivers/base/dd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-next-20220228.orig/drivers/base/dd.c
> +++ linux-next-20220228/drivers/base/dd.c
> @@ -810,7 +810,7 @@ static int __init save_async_options(cha
>  		pr_warn("Too long list of driver names for 'driver_async_probe'!\n");
>  
>  	strlcpy(async_probe_drv_names, buf, ASYNC_DRV_NAMES_MAX_LEN);
> -	return 0;
> +	return 1;
>  }
>  __setup("driver_async_probe=", save_async_options);
>