linux-kernel - Re: [PATCH] input: keyboard: snvs_pwrkey: Fix SNVS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d73eed98b74535f0b67b843d9c40cac11b41bcb6.camel@puri.sm>
Date:   Tue, 01 Mar 2022 09:07:34 +0100
From:   Martin Kepplinger <martin.kepplinger@...i.sm>
To:     Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org
Cc:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Robin van der Gracht <robin@...tonic.nl>,
        linux-kernel@...r.kernel.org, kernel@...i.sm
Subject: Re: [PATCH] input: keyboard: snvs_pwrkey: Fix SNVS_HPVIDR1 register
 address

Am Montag, dem 28.02.2022 um 19:46 +0100 schrieb Sebastian
Krzyszkowiak:
> Both i.MX6 and i.MX8 reference manuals list 0xBF8 as SNVS_HPVIDR1
> (chapters 57.9 and 6.4.5 respectively).
> 
> Fixes: 1a26c920717a ("Input: snvs_pwrkey - send key events for i.MX6
> S, DL and Q")
> Signed-off-by: Sebastian Krzyszkowiak
> <sebastian.krzyszkowiak@...i.sm>

Tested-by: Martin Kepplinger <martin.kepplinger@...i.sm>

using evemu-record. Because the commit message doesn't describe it:
Without this, when "pressing" power key, events "1" and "0" together
would be delivered in one. With this fix, it's only "1", and when
"releasing" we see the "0" event as expected.

thank you,
                             martin


> ---
>  drivers/input/keyboard/snvs_pwrkey.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/keyboard/snvs_pwrkey.c
> b/drivers/input/keyboard/snvs_pwrkey.c
> index 65286762b02a..ad8660be0127 100644
> --- a/drivers/input/keyboard/snvs_pwrkey.c
> +++ b/drivers/input/keyboard/snvs_pwrkey.c
> @@ -20,7 +20,7 @@
>  #include <linux/mfd/syscon.h>
>  #include <linux/regmap.h>
>  
> -#define SNVS_HPVIDR1_REG       0xF8
> +#define SNVS_HPVIDR1_REG       0xBF8
>  #define SNVS_LPSR_REG          0x4C    /* LP Status Register */
>  #define SNVS_LPCR_REG          0x38    /* LP Control Register */
>  #define SNVS_HPSR_REG          0x14