linux-kernel - [amir73il:sb_iostats 4/8] include/linux/fs.h:3648:15: error: implicit declaration of function 'percpu_counters_init'; did you mean 'percpu_counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 1 Mar 2022 09:05:24 +0800
From:   kernel test robot <lkp@...el.com>
To:     Amir Goldstein <amir73il@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [amir73il:sb_iostats 4/8] include/linux/fs.h:3648:15: error:
 implicit declaration of function 'percpu_counters_init'; did you mean
 'percpu_counter_init'?

tree:   https://github.com/amir73il/linux sb_iostats
head:   ecfdb413f2105083296e9cb45290eb1f01b0ef5c
commit: 8b022d3080d57a2a42917c1b36d7b4c27a4fac4e [4/8] fs: add iostats counters to struct super_block
config: xtensa-allyesconfig (https://download.01.org/0day-ci/archive/20220301/202203010903.oFHcgc04-lkp@intel.com/config)
compiler: xtensa-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/amir73il/linux/commit/8b022d3080d57a2a42917c1b36d7b4c27a4fac4e
        git remote add amir73il https://github.com/amir73il/linux
        git fetch --no-tags amir73il sb_iostats
        git checkout 8b022d3080d57a2a42917c1b36d7b4c27a4fac4e
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=xtensa prepare

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from include/linux/huge_mm.h:8,
                    from include/linux/mm.h:697,
                    from include/linux/pid_namespace.h:7,
                    from include/linux/ptrace.h:10,
                    from arch/xtensa/kernel/asm-offsets.c:21:
   include/linux/fs.h: In function 'sb_iostats_init':
>> include/linux/fs.h:3648:15: error: implicit declaration of function 'percpu_counters_init'; did you mean 'percpu_counter_init'? [-Werror=implicit-function-declaration]
    3648 |         err = percpu_counters_init(sb->s_iostats.counter,
         |               ^~~~~~~~~~~~~~~~~~~~
         |               percpu_counter_init
   include/linux/fs.h: In function 'sb_iostats_destroy':
>> include/linux/fs.h:3666:17: error: implicit declaration of function 'percpu_counters_destroy'; did you mean 'percpu_counter_destroy'? [-Werror=implicit-function-declaration]
    3666 |                 percpu_counters_destroy(sb->s_iostats.counter,
         |                 ^~~~~~~~~~~~~~~~~~~~~~~
         |                 percpu_counter_destroy
   cc1: some warnings being treated as errors
   make[2]: *** [scripts/Makefile.build:121: arch/xtensa/kernel/asm-offsets.s] Error 1
   make[2]: Target '__build' not remade because of errors.
   make[1]: *** [Makefile:1191: prepare0] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:219: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.


vim +3648 include/linux/fs.h

  3641	
  3642	#ifdef CONFIG_FS_IOSTATS
  3643	/* Initialize per-sb I/O stats */
  3644	static inline int sb_iostats_init(struct super_block *sb)
  3645	{
  3646		int err;
  3647	
> 3648		err = percpu_counters_init(sb->s_iostats.counter,
  3649					   SB_IOSTATS_COUNTERS_NUM, 0, GFP_KERNEL);
  3650		if (!err) {
  3651			sb->s_iflags |= SB_I_IOSTATS;
  3652			sb->s_iostats.start_time = ktime_get_seconds();
  3653		}
  3654	
  3655		return err;
  3656	}
  3657	
  3658	static inline bool sb_has_iostats(struct super_block *sb)
  3659	{
  3660		return (sb->s_iflags & SB_I_IOSTATS);
  3661	}
  3662	
  3663	static inline void sb_iostats_destroy(struct super_block *sb)
  3664	{
  3665		if (sb_has_iostats(sb))
> 3666			percpu_counters_destroy(sb->s_iostats.counter,
  3667						SB_IOSTATS_COUNTERS_NUM);
  3668	}
  3669	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org