linux-kernel - Re: [PATCH] drm/bridge: anx7625: Fix release wrong workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Mar 2022 16:58:31 +0800
From:   Hsin-Yi Wang <hsinyi@...omium.org>
To:     Xin Ji <xji@...logixsemi.com>
Cc:     andrzej.hajda@...el.com, Neil Armstrong <narmstrong@...libre.com>,
        Robert Foss <robert.foss@...aro.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Jonas Karlman <jonas@...boo.se>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, bliang@...logixsemi.com,
        qwen@...logixsemi.com,
        Xin Ji <xji@...logix.corp-partner.google.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: anx7625: Fix release wrong workqueue

On Thu, Feb 17, 2022 at 11:02 AM Hsin-Yi Wang <hsinyi@...omium.org> wrote:
>
> On Thu, Feb 17, 2022 at 10:45 AM Xin Ji <xji@...logixsemi.com> wrote:
> >
> > From: Xin Ji <xji@...logix.corp-partner.google.com>
> >
> > If "hdcp_workqueue" exist, must release "hdcp_workqueue",
> > not "workqueue".
> >
> > Fixes: cd1637c7e480 ("drm/bridge: anx7625: add HDCP support")
> > Signed-off-by: Xin Ji <xji@...logixsemi.com>
> > ---
> Reviewed-by: Hsin-Yi Wang <hsinyi@...omium.org>
>
> This fixes an issue that the driver will crash during unbind.
>
Hi Robert,

Kindly ping on this fix. Thanks.

> >  drivers/gpu/drm/bridge/analogix/anx7625.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > index 633618bafd75..9aab879a8851 100644
> > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c
> > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c
> > @@ -2736,8 +2736,8 @@ static int anx7625_i2c_remove(struct i2c_client *client)
> >
> >         if (platform->hdcp_workqueue) {
> >                 cancel_delayed_work(&platform->hdcp_work);
> > -               flush_workqueue(platform->workqueue);
> > -               destroy_workqueue(platform->workqueue);
> > +               flush_workqueue(platform->hdcp_workqueue);
> > +               destroy_workqueue(platform->hdcp_workqueue);
> >         }
> >
> >         if (!platform->pdata.low_power_mode)
> > --
> > 2.25.1
> >