linux-kernel - Re: [PATCH v4 0/4] MIPS: Modify mem= and memmap= parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yh3tgr+g/6IElq0P@kernel.org>
Date:   Tue, 1 Mar 2022 11:55:14 +0200
From:   Mike Rapoport <rppt@...nel.org>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Xuefeng Li <lixuefeng@...ngson.cn>, linux-mips@...r.kernel.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 0/4] MIPS: Modify mem= and memmap= parameter

Hi,

On Tue, Mar 01, 2022 at 12:28:57PM +0800, Tiezhu Yang wrote:
> In the current code, the kernel command-line parameter mem= and memmap=
> can not work well on MIPS, this patchset refactors the related code to
> fix them.
> 
> For kdump on MIPS, if the users want to limit the memory region for the
> capture kernel to avoid corrupting the memory image of the panic kernel,
> use the parameter memmap=limit@...e is the proper way, I will submit a
> patch to use memmap=limit@...e for kexec-tools after this patchset is
> applied.

Sorry, apparently I misread the prevoius version.
What's wrong with the current implementation of mem=limit@...e for the
kdump case?
 
> v4: Fix some build warnings reported by kernel test robot
> 
> v3: Modify patch #3 to maintain compatibility for memmap=limit{$,#,!}base,
>     commented by Mike Rapoport, thank you
> 
> v2: Add some new patches to support memmap=limit@...e
> 
> Tiezhu Yang (4):
>   MIPS: Refactor early_parse_mem() to fix mem= parameter
>   memblock: Introduce memblock_mem_range_remove_map()
>   MIPS: Refactor early_parse_memmap() to fix memmap= parameter
>   MIPS: Remove not used variable usermem
> 
>  arch/mips/kernel/setup.c | 69 ++++++++++++++++++++++--------------------------
>  include/linux/memblock.h |  1 +
>  mm/memblock.c            |  9 +++++--
>  3 files changed, 40 insertions(+), 39 deletions(-)
> 
> -- 
> 2.1.0
> 

-- 
Sincerely yours,
Mike.