linux-kernel - Re: [PATCH v4 2/2] drm/mediatek: add devlink to cmdq dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 1 Mar 2022 09:46:42 +0800
From:   Jason-JH Lin <jason-jh.lin@...iatek.com>
To:     Chun-Kuang Hu <chunkuang.hu@...nel.org>
CC:     Philipp Zabel <p.zabel@...gutronix.de>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <tzungbi@...gle.com>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Hsin-Yi Wang <hsinyi@...omium.org>,
        "Fei Shao" <fshao@...omium.org>,
        Nancy Lin <nancy.lin@...iatek.com>, <singo.chang@...iatek.com>
Subject: Re: [PATCH v4 2/2] drm/mediatek: add devlink to cmdq dev

Hi Chun-Kuang,

Thanks for the reviews.

I forgot to add the comment that the patch should be based on [1].
We can only apply it after applying [1].

So please apply it after that. Thank you very much!

Regards,
Jason-JH.Lin
---
[1] drm/mediatek: modify mediatek-drm for mt8195 multi mmsys support

https://patchwork.kernel.org/project/linux-mediatek/patch/20220222100741.30138-21-nancy.lin@mediatek.com/
---

On Sun, 2022-02-27 at 11:33 +0800, Chun-Kuang Hu wrote:
> Hi, Jason:
> 
> Build error:
> 
> ../drivers/gpu/drm/mediatek/mtk_drm_crtc.c: In function
> ‘mtk_drm_crtc_create’:
> ../drivers/gpu/drm/mediatek/mtk_drm_crtc.c:902:26: error: ‘struct
> mtk_drm_private’ has no member named ‘dev’
>   mtk_crtc->drm_dev = priv->dev;
>                           ^
> ../drivers/gpu/drm/mediatek/mtk_drm_crtc.c:974:30: error: ‘struct
> mtk_drm_private’ has no member named ‘dev’
>    link = device_link_add(priv->dev, mtk_crtc->cmdq_client.chan-
> >mbox->dev,
>                               ^
> In file included from ../include/linux/device.h:15:0,
>                  from ../include/linux/dma-mapping.h:7,
>                  from ../drivers/gpu/drm/mediatek/mtk_drm_crtc.c:7:
> ../drivers/gpu/drm/mediatek/mtk_drm_crtc.c:977:16: error: ‘struct
> mtk_drm_private’ has no member named ‘dev’
>     dev_err(priv->dev, "Unable to link dev=%s\n",
>                 ^
> Regards,
> Chun-Kuang.