linux-kernel - Re: [PATCH -next] ASoC: amd: Fix an ignored error return from platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 1 Mar 2022 12:39:52 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Yang Li <yang.lee@...ux.alibaba.com>
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        tangmeng@...ontech.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] ASoC: amd: Fix an ignored error return from
 platform_get_irq_byname()

On Tue, Mar 01, 2022 at 02:49:20PM +0800, Yang Li wrote:

> -	adata->i2s_irq = platform_get_irq_byname(pdev, "acp_dai_irq");
> -	if (adata->i2s_irq < 0)
> +	adata->i2s_irq = ret = platform_get_irq_byname(pdev, "acp_dai_irq");
> +	if (ret < 0)
>  		return -ENODEV;

If an error code is being returned we should report that error code
rather than squashing it down to -ENODEV.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)