linux-kernel - Re: [PATCH] ASoC: atmel_ssc_dai: Handle errors for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yh4VoWfDxUOBGRBg@sirena.org.uk>
Date:   Tue, 1 Mar 2022 12:46:25 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Alexandre Belloni <alexandre.belloni@...tlin.com>
Cc:     Jiasheng Jiang <jiasheng@...as.ac.cn>,
        codrin.ciubotariu@...rochip.com, lgirdwood@...il.com,
        perex@...ex.cz, tiwai@...e.com, nicolas.ferre@...rochip.com,
        claudiu.beznea@...rochip.com, alsa-devel@...a-project.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: atmel_ssc_dai: Handle errors for clk_enable

On Tue, Mar 01, 2022 at 12:18:32PM +0100, Alexandre Belloni wrote:
> On 01/03/2022 17:06:37+0800, Jiasheng Jiang wrote:
> > As the potential failure of the clk_enable(),
> > it should be better to check it and return error if fals.

> As I already replied to an earlier patch, this will never, ever fail,
> this patch doesn't fix anything.

OTOH it doesn't do too much harm to have the error checking and it means
people don't have to check if this is a case where it doesn't matter.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)