linux-kernel - Re: [PATCH] Asoc: au1x: Use devm_snd_soc_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yh4fdXOUKNeV7Mi5@sirena.org.uk>
Date:   Tue, 1 Mar 2022 13:28:21 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Zhen Ni <nizhen@...ontech.com>
Cc:     lgirdwood@...il.com, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Asoc: au1x: Use devm_snd_soc_register_component()

On Tue, Mar 01, 2022 at 05:23:22PM +0800, Zhen Ni wrote:

> +++ b/sound/soc/au1x/psc-ac97.c
> @@ -411,7 +411,7 @@ static int au1xpsc_ac97_drvprobe(struct platform_device *pdev)
>  	if (ret)
>  		return ret;
>  
> -	ret = snd_soc_register_component(&pdev->dev, &au1xpsc_ac97_component,
> +	ret = devm_snd_soc_register_component(&pdev->dev, &au1xpsc_ac97_component,
>  					 &wd->dai_drv, 1);
>  	if (ret)
>  		return ret;
> -- 

This introduces a double free since there is a remove() function which
calls snd_soc_unregister_component().

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)