linux-kernel - [PATCH] SO_ZEROCOPY should rather return -ENOPROTOOPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220301144453.snstwdjy3kmpi4zf@begin>
Date:   Tue, 1 Mar 2022 15:44:53 +0100
From:   Samuel Thibault <samuel.thibault@...ri.fr>
To:     willemb@...gle.com
Cc:     davem@...emloft.net, kuba@...nel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] SO_ZEROCOPY should rather return -ENOPROTOOPT

ENOTSUPP is documented as "should never be seen by user programs", and
is not exposed in <errno.h>, so applications cannot safely check against
it. We should rather return the well-known -ENOPROTOOPT.

Signed-off-by: Samuel Thibault <samuel.thibault@...ri.fr>

diff --git a/net/core/sock.c b/net/core/sock.c
index 4ff806d71921..6e5b84194d56 100644
--- a/net/core/sock.c
+++ b/net/core/sock.c
@@ -1377,9 +1377,9 @@ int sock_setsockopt(struct socket *sock, int level, int optname,
 			if (!(sk_is_tcp(sk) ||
 			      (sk->sk_type == SOCK_DGRAM &&
 			       sk->sk_protocol == IPPROTO_UDP)))
-				ret = -ENOTSUPP;
+				ret = -ENOPROTOOPT;
 		} else if (sk->sk_family != PF_RDS) {
-			ret = -ENOTSUPP;
+			ret = -ENOPROTOOPT;
 		}
 		if (!ret) {
 			if (val < 0 || val > 1)