linux-kernel - Re: [PATCH] KVM: x86/mmu: Passing up the error state of mmu_alloc_shadow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Mar 2022 15:47:28 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Like Xu <like.xu.linux@...il.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Joerg Roedel <joro@...tes.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: x86/mmu: Passing up the error state of
 mmu_alloc_shadow_roots()

On Tue, Mar 01, 2022, Like Xu wrote:
> From: Like Xu <likexu@...cent.com>
> 
> Just like on the optional mmu_alloc_direct_roots() path, once shadow
> path reaches "r = -EIO" somewhere, the caller needs to know the actual
> state in order to enter error handling and avoid something worse.

Well that's emabarrassing.

> Fixes: 4a38162ee9f1 ("KVM: MMU: load PDPTRs outside mmu_lock")

Cc: stable@...r.kernel.org

> Signed-off-by: Like Xu <likexu@...cent.com>
> ---

Reviewed-by: Sean Christopherson <seanjc@...gle.com>