linux-kernel - Re: [PATCH V3] tty: serial: meson: Fix the compile link error reported by kernel test robot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aa9c6622-4d3c-5bb8-ba25-d25b8b73a038@amlogic.com>
Date:   Tue, 1 Mar 2022 10:43:47 +0800
From:   Yu Tu <yu.tu@...ogic.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Dan Carpenter <dan.carpenter@...cle.com>
CC:     <linux-serial@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-amlogic@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, Jiri Slaby <jirislaby@...nel.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH V3] tty: serial: meson: Fix the compile link error
 reported by kernel test robot

Hi greg and dan,
	Thank you very much for your reply. I will make a separate submission 
as you suggested to fix Dan's suggestion.

On 2022/3/1 5:23, Greg Kroah-Hartman wrote:
> [ EXTERNAL EMAIL ]
> 
> On Mon, Feb 28, 2022 at 05:27:52PM +0300, Dan Carpenter wrote:
>> On Mon, Feb 28, 2022 at 09:55:30PM +0800, Yu Tu wrote:
>>> Describes the calculation of the UART baud rate clock using a clock
>>> frame. Forgot to add in Kconfig kernel test Robot compilation error
>>> due to COMMON_CLK dependency.
>>>
>>> Fixes: ("tty: serial:meson: Describes the calculation of the UART baud rate clock using a clock frame“)
>>> Reported-by: kernel test robot <lkp@...el.com>
>>> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
>>> Signed-off-by: Yu Tu <yu.tu@...ogic.com>
>>> ---
>>>   drivers/tty/serial/Kconfig      |  1 +
>>>   drivers/tty/serial/meson_uart.c | 37 +++++++++++++++++++++++----------
>>>   2 files changed, 27 insertions(+), 11 deletions(-)
>>>
>>> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
>>> index e952ec5c7a7c..a0f2b82fc18b 100644
>>> --- a/drivers/tty/serial/Kconfig
>>> +++ b/drivers/tty/serial/Kconfig
>>> @@ -200,6 +200,7 @@ config SERIAL_KGDB_NMI
>>>   config SERIAL_MESON
>>>   	tristate "Meson serial port support"
>>>   	depends on ARCH_MESON || COMPILE_TEST
>>> +	depends on COMMON_CLK
>>>   	select SERIAL_CORE
>>>   	help
>>>   	  This enables the driver for the on-chip UARTs of the Amlogic
>>
>>
>> This is a link issue.  The rest is an unrelated error handling fix.
>> It should really be sent as two patches.
> 
> I'll take the first version of this patch, which just did this portion,
> and the rest can be an independant change.
> 
> thanks,
> 
> greg k-h
>