lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20220302190501.GA2168@9a2d8922b8f1> Date: Thu, 3 Mar 2022 00:35:01 +0530 From: Kuldeep Singh <singh.kuldeep87k@...il.com> To: Robin Murphy <robin.murphy@....com> Cc: Mark Brown <broonie@...nel.org>, linux-arm-kernel@...ts.infradead.org, linux-spi@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>, Linus Walleij <linus.walleij@...aro.org> Subject: Re: [PATCH 3/3] dt-bindings: spi: Add spiclk to clock-names property in pl022 On Mon, Feb 28, 2022 at 02:36:23PM +0000, Robin Murphy wrote: > On 2022-02-28 12:43, Kuldeep Singh wrote: > > Fix below dtc warning by making necessary addition of "spiclk" in > > clock-names property. > > > > arch/arm64/boot/dts/broadcom/stingray/bcm958742t.dt.yaml: spi@...000: > > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] > > From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml > > arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dt.yaml: spi@...90000: > > clock-names:0: 'spiclk' is not one of ['SSPCLK', 'sspclk'] > > From schema: Documentation/devicetree/bindings/spi/spi-pl022.yaml > > As before, what makes the binding at fault rather than that DT? The PL022's > actual input is named SSPCLK, not SPICLK, so why should a driver which wants > to look up that clock by name expect to look for "spiclk"? That's right. It's the DT which is at the fault of defining spiclk instead of sspclk and need to be fixed in DT itself. I didn't take a look at pl022 doc and acted on the basis of DT info. Moreover, DT also uses sspclk and SSPCLK names interchangeably which are anyway same. This also require updation to follow single convention. Appreciate your comments and valuable inputs. -- Best Regards Kuldeep
Powered by blists - more mailing lists