linux-kernel - Re: [syzbot] KASAN: use-after-free Read in dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yh/BF2bx1TT3DMPG@rowland.harvard.edu>
Date:   Wed, 2 Mar 2022 14:10:15 -0500
From:   "stern@...land.harvard.edu" <stern@...land.harvard.edu>
To:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:     "Zhang, Qiang1" <qiang1.zhang@...el.com>,
        Tejun Heo <tj@...nel.org>,
        syzbot <syzbot+348b571beb5eeb70a582@...kaller.appspotmail.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "syzkaller-bugs@...glegroups.com" <syzkaller-bugs@...glegroups.com>,
        "balbi@...nel.org" <balbi@...nel.org>
Subject: Re: [syzbot] KASAN: use-after-free Read in dev_uevent

On Sat, Feb 26, 2022 at 10:07:02AM +0100, gregkh@...uxfoundation.org wrote:
> On Fri, Feb 25, 2022 at 10:51:48AM -0500, stern@...land.harvard.edu wrote:
> > On Fri, Feb 25, 2022 at 09:53:35AM +0100, gregkh@...uxfoundation.org wrote:
> > > The aux bus might make this easier:
> > > 	Documentation/driver-api/auxiliary_bus.rst
> > 
> > Won't this end up changing the user-visible filenames and directories in 
> > sysfs for gadgets and gadget drivers?
> > 
> > For instance, currently gadgets get registered under their UDC driver 
> > name, like "net2280" or "at91".  If we put them on the aux bus then they 
> > will have to get registered under a name looking something like 
> > "udc.gadget.0", i.e., module name, generic device name, and ID number.
> 
> Ah, yeah, that isn't good.
> 
> > We will be forced to use a generic device name because the aux bus does 
> > matching based on it, and we want every gadget driver to be able to 
> > match every UDC.  We don't want some gadget drivers restricted to 
> > net2280 gadgets, others restricted to fotg210 gadgets, and so on.
> 
> So yes, I guess it does need to be a "real" bus, sorry.

It turns out not to be so bad.  In fact there are only five
gadget drivers (that is, instances of struct usb_gadget_driver) in the 
kernel:

	composite_driver_template	(gadget/composite.c)
	configfs_driver_template	(gadget/configfs.c)
	gadgetfs_driver			(gadget/legacy/inode.c)
	driver				(gadget/legacy/raw_gadget.c)
	dbgp_driver			(gadget/legacy/dbgp.c)

Everything else is implemented as a "function" driver.  So the gadget 
driver's name doesn't mean very much to the user anyway.

The interaction between the gadget subsystem and the device core is 
rather peculiar.  Each UDC controller is represented by a pair of device 
structures: the .dev fields in struct usb_udc and struct usb_gadget.  
These two are siblings -- they always have the same parent (see 
usb_add_gadget() in gadget/udc/core.c).  Furthermore, they have the same 
driver; that is, udc->dev.driver is always the same as 
gadget->dev.driver (see udc_bind_to_driver()).  Which is doubly odd, 
because gadget drivers manage only gadget devices, not udc devices.  The 
major difference between them is that the usb_udc is a class device 
whereas the usb_gadget is a "real" device.

Currently neither the udc device nor the gadget device is registered on 
any bus.  IMO it would make sense to leave udc->dev.driver always set to 
NULL, keep the udc devices bus-less, and put the gadget devices on the 
aux bus.

Does that sound reasonable?  I'll work on a patch to do it.

Alan Stern