lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <0C35F358-3E66-457E-9080-DAE4EB10BF16@holtmann.org> Date: Wed, 2 Mar 2022 20:16:39 +0100 From: Marcel Holtmann <marcel@...tmann.org> To: Caleb Connolly <caleb.connolly@...aro.org> Cc: Johan Hedberg <johan.hedberg@...il.com>, Luiz Augusto von Dentz <luiz.dentz@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, BlueZ <linux-bluetooth@...r.kernel.org>, "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, linux-arm-msm@...r.kernel.org Subject: Re: [PATCH] bluetooth: hci_event: don't print an error on vendor events Hi Caleb, > Since commit 3e54c5890c87 ("Bluetooth: hci_event: Use of a function table to handle HCI events"), > some devices see errors being printed for vendor events, e.g. > > [ 75.806141] Bluetooth: hci0: setting up wcn399x > [ 75.948311] Bluetooth: hci0: unexpected event 0xff length: 14 > 0 > [ 75.955552] Bluetooth: hci0: QCA Product ID :0x0000000a > [ 75.961369] Bluetooth: hci0: QCA SOC Version :0x40010214 > [ 75.967417] Bluetooth: hci0: QCA ROM Version :0x00000201 > [ 75.973363] Bluetooth: hci0: QCA Patch Version:0x00000001 > [ 76.000289] Bluetooth: hci0: QCA controller version 0x02140201 > [ 76.006727] Bluetooth: hci0: QCA Downloading qca/crbtfw21.tlv > [ 76.986850] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.013574] Bluetooth: hci0: QCA Downloading qca/oneplus6/crnv21.bin > [ 77.024302] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.032681] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.040674] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.049251] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.057997] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.066320] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.075065] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.083073] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.091250] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.099417] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.110166] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.118672] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.127449] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.137190] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.146192] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.154242] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.163183] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.171202] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.179364] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.187259] Bluetooth: hci0: unexpected event 0xff length: 3 > 0 > [ 77.198451] Bluetooth: hci0: QCA setup on UART is completed > > Use the quick-return path in hci_event_func() to avoid printing this > message for vendor events, this reverts to the previous behaviour which > didn't print an error for vendor events. > > Fixes: 3e54c5890c87 ("Bluetooth: hci_event: Use of a function table to handle HCI events") > Signed-off-by: Caleb Connolly <caleb.connolly@...aro.org> > --- > net/bluetooth/hci_event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) patch has been applied to bluetooth-stable tree. Regards Marcel
Powered by blists - more mailing lists