linux-kernel - Re: Re: [PATCH] ASoC: fsi: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20220302031148.46395-1-jiasheng@iscas.ac.cn>
Date:   Wed,  2 Mar 2022 11:11:48 +0800
From:   Jiasheng Jiang <jiasheng@...as.ac.cn>
To:     broonie@...nel.org
Cc:     lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.com,
        ast@...nel.org, daniel@...earbox.net, andrii@...nel.org,
        kafai@...com, songliubraving@...com, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org, f.suligoi@...m.it,
        kuninori.morimoto.gx@...esas.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org, Jiasheng Jiang <jiasheng@...as.ac.cn>
Subject: Re: Re: [PATCH] ASoC: fsi: Add check for clk_enable

On Tue, Mar 01, 2022 at 08:44:12PM +0800, Mark Brown wrote:
>> +err:
>> +	clk_disable(clock->xck);
>> +	clk_disable(clock->ick);
>> +	clk_disable(clock->div);
> 
> You need separate labels for each enable so that we don't end up
> disabling clocks we didn't enable, that would also be a bug.

Thanks, I have submitted a v2 to fix it.

Jiang