lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Thu, 3 Mar 2022 05:38:57 +0800
From:   kernel test robot <lkp@...el.com>
To:     Roman Kiryanov <rkir@...gle.com>
Cc:     kbuild-all@...ts.01.org,
        GNU/Weeb Mailing List <gwml@...r.gnuweeb.org>,
        linux-kernel@...r.kernel.org, Lingfeng Yang <lfy@...gle.com>
Subject: [ammarfaizi2-block:google/android/kernel/common/deprecated/android-4.4-p-release
 8768/9922] drivers/platform/goldfish/goldfish_pipe_v2.c:814:21: warning:
 format '%llx' expects argument of type 'long long unsigned int', but
 argument 4 has type 'dma_addr_t {aka unsigned int}'

Hi Roman,

FYI, the error/warning still remains.

tree:   https://github.com/ammarfaizi2/linux-block google/android/kernel/common/deprecated/android-4.4-p-release
head:   c159ade87311501e4e4b40eb2f35aa5607732957
commit: 3702e76fb6e907cc75887fe5780fe160946e7c68 [8768/9922] goldfish: pipe: ANDROID: Add DMA support
config: i386-randconfig-a012-20211118 (https://download.01.org/0day-ci/archive/20220303/202203030511.uZ7gsNlS-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build):
        # https://github.com/ammarfaizi2/linux-block/commit/3702e76fb6e907cc75887fe5780fe160946e7c68
        git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
        git fetch --no-tags ammarfaizi2-block google/android/kernel/common/deprecated/android-4.4-p-release
        git checkout 3702e76fb6e907cc75887fe5780fe160946e7c68
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/platform/goldfish/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:277:0,
                    from drivers/platform/goldfish/goldfish_pipe_v2.c:49:
   drivers/platform/goldfish/goldfish_pipe_v2.c: In function 'goldfish_pipe_dma_release_host':
>> drivers/platform/goldfish/goldfish_pipe_v2.c:814:21: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
      dev_dbg(pdev_dev, "Last ref for dma region @ 0x%llx\n",
                        ^
       dma->phys_begin);
       ~~~~~~            
   include/linux/dynamic_debug.h:86:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^~~
   drivers/platform/goldfish/goldfish_pipe_v2.c:814:3: note: in expansion of macro 'dev_dbg'
      dev_dbg(pdev_dev, "Last ref for dma region @ 0x%llx\n",
      ^~~~~~~
   drivers/platform/goldfish/goldfish_pipe_v2.c:824:3: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
      "after delete of dma @ 0x%llx: alloc total %zu\n",
      ^
      dma->phys_begin, pipe->dev->dma_alloc_total);
      ~~~~~~
   include/linux/dynamic_debug.h:86:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^~~
   drivers/platform/goldfish/goldfish_pipe_v2.c:823:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(pdev_dev,
     ^~~~~~~
   drivers/platform/goldfish/goldfish_pipe_v2.c: In function 'goldfish_pipe_dma_release_guest':
   drivers/platform/goldfish/goldfish_pipe_v2.c:847:4: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
       "after delete of dma @ 0x%llx: alloc total %zu\n",
       ^
       dma->phys_begin, pipe->dev->dma_alloc_total);
       ~~~~~~
   include/linux/dynamic_debug.h:86:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^~~
   drivers/platform/goldfish/goldfish_pipe_v2.c:846:3: note: in expansion of macro 'dev_dbg'
      dev_dbg(pdev_dev,
      ^~~~~~~
   drivers/platform/goldfish/goldfish_pipe_v2.c: In function 'goldfish_pipe_dma_alloc_locked':
   drivers/platform/goldfish/goldfish_pipe_v2.c:956:20: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 6 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
     dev_dbg(pdev_dev, "%s: got v/p addrs "
                       ^
   drivers/platform/goldfish/goldfish_pipe_v2.c:960:3:
      dma->phys_begin,
      ~~~~~~            
   include/linux/dynamic_debug.h:86:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^~~
   drivers/platform/goldfish/goldfish_pipe_v2.c:956:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(pdev_dev, "%s: got v/p addrs "
     ^~~~~~~
   drivers/platform/goldfish/goldfish_pipe_v2.c:957:12: note: format string is defined here
      "%p 0x%llx sz %zu total alloc %zu\n",
            ~~~^
            %x
   In file included from include/linux/printk.h:277:0,
                    from drivers/platform/goldfish/goldfish_pipe_v2.c:49:
   drivers/platform/goldfish/goldfish_pipe_v2.c: In function 'goldfish_dma_mmap_locked':
   drivers/platform/goldfish/goldfish_pipe_v2.c:982:20: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
     dev_dbg(pdev_dev, "Mapping dma at 0x%llx\n", dma->phys_begin);
                       ^                          ~~~~~~
   include/linux/dynamic_debug.h:86:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^~~
   drivers/platform/goldfish/goldfish_pipe_v2.c:982:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(pdev_dev, "Mapping dma at 0x%llx\n", dma->phys_begin);
     ^~~~~~~
   drivers/platform/goldfish/goldfish_pipe_v2.c:1003:20: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 4 has type 'dma_addr_t {aka unsigned int}' [-Wformat=]
     dev_dbg(pdev_dev, "goldfish_dma_mmap for host vaddr 0x%llx succeeded\n",
                       ^
      dma->phys_begin);
      ~~~~~~            
   include/linux/dynamic_debug.h:86:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^~~
   drivers/platform/goldfish/goldfish_pipe_v2.c:1003:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(pdev_dev, "goldfish_dma_mmap for host vaddr 0x%llx succeeded\n",
     ^~~~~~~
   drivers/platform/goldfish/goldfish_pipe_v2.c: At top level:
   drivers/platform/goldfish/goldfish_pipe_v2.c:1059:6: warning: no previous declaration for 'goldfish_dma_ioctl_getoff' [-Wmissing-declarations]
    long goldfish_dma_ioctl_getoff(struct goldfish_pipe *pipe, unsigned long arg)
         ^~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/platform/goldfish/goldfish_pipe_v2.c:1096:6: warning: no previous declaration for 'goldfish_dma_ioctl_create_region' [-Wmissing-declarations]
    long goldfish_dma_ioctl_create_region(struct goldfish_pipe *pipe,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/platform/goldfish/goldfish_pipe_v2.c: In function 'transfer_max_buffers':
   drivers/platform/goldfish/goldfish_pipe_v2.c:407:1: warning: the frame size of 1384 bytes is larger than 1024 bytes [-Wframe-larger-than=]
    }
    ^
   arch/x86/include/asm/bitops.h: Assembler messages:
   arch/x86/include/asm/bitops.h:206: Warning: no instruction mnemonic suffix given and no register operands; using default for `bts'


vim +814 drivers/platform/goldfish/goldfish_pipe_v2.c

   802	
   803	static void goldfish_pipe_dma_release_host(struct goldfish_pipe *pipe)
   804	{
   805		struct goldfish_dma_context *dma = pipe->dma;
   806		struct device *pdev_dev;
   807	
   808		if (!dma)
   809			return;
   810	
   811		pdev_dev = pipe->dev->pdev_dev;
   812	
   813		if (dma->dma_vaddr) {
 > 814			dev_dbg(pdev_dev, "Last ref for dma region @ 0x%llx\n",
   815				dma->phys_begin);
   816	
   817			pipe->command_buffer->dma_maphost_params.dma_paddr =
   818				dma->phys_begin;
   819			pipe->command_buffer->dma_maphost_params.sz = dma->dma_size;
   820			goldfish_pipe_cmd(pipe, PIPE_CMD_DMA_HOST_UNMAP);
   821		}
   822	
   823		dev_dbg(pdev_dev,
   824			"after delete of dma @ 0x%llx: alloc total %zu\n",
   825			dma->phys_begin, pipe->dev->dma_alloc_total);
   826	}
   827	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ