lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Yh/nAUkt8iZlvQdc@bombadil.infradead.org> Date: Wed, 2 Mar 2022 13:52:01 -0800 From: Luis Chamberlain <mcgrof@...nel.org> To: "Eric W. Biederman" <ebiederm@...ssion.com> Cc: Shakeel Butt <shakeelb@...gle.com>, Colin Ian King <colin.king@...onical.com>, NeilBrown <neilb@...e.de>, Vasily Averin <vvs@...tuozzo.com>, Vlastimil Babka <vbabka@...e.cz>, Michal Hocko <mhocko@...e.com>, Roman Gushchin <roman.gushchin@...ux.dev>, Linux MM <linux-mm@...ck.org>, netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Tejun Heo <tj@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Eric Dumazet <edumazet@...gle.com>, Kees Cook <keescook@...omium.org>, Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>, David Ahern <dsahern@...nel.org>, linux-kernel@...r.kernel.org, kernel@...nvz.org Subject: Re: [PATCH RFC] net: memcg accounting for veth devices On Wed, Mar 02, 2022 at 08:43:54AM -0600, Eric W. Biederman wrote: > Luis Chamberlain <mcgrof@...nel.org> writes: > > > On Tue, Mar 01, 2022 at 02:50:06PM -0600, Eric W. Biederman wrote: > >> I really have not looked at this pids controller. > >> > >> So I am not certain I understand your example here but I hope I have > >> answered your question. > > > > During experimentation with the above stress-ng test case, I saw tons > > of thread just waiting to do exit: > > You increment the count of concurrent threads after a no return function > in do_exit. Since the increment is never reached the count always goes > down and eventually the warning prints. > > > diff --git a/kernel/exit.c b/kernel/exit.c > > index 80c4a67d2770..653ca7ebfb58 100644 > > --- a/kernel/exit.c > > +++ b/kernel/exit.c > > @@ -881,6 +894,9 @@ void __noreturn do_exit(long code) > > > > lockdep_free_task(tsk); > > do_task_dead(); > > The function do_task_dead never returns. > > > + > > + atomic_inc(&exit_concurrent_max); > > + wake_up(&exit_wq); > > } > > EXPORT_SYMBOL_GPL(do_exit); Doh thanks! Luis
Powered by blists - more mailing lists