lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Yh/yr6oB5yeOUErL@silpixa00400314> Date: Wed, 2 Mar 2022 22:42:20 +0000 From: Giovanni Cabiddu <giovanni.cabiddu@...el.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: Greg KH <gregkh@...uxfoundation.org>, Linus Torvalds <torvalds@...ux-foundation.org>, Kyle Sanderson <kyle.leet@...il.com>, Dave Chinner <david@...morbit.com>, qat-linux@...el.com, Linux-Kernal <linux-kernel@...r.kernel.org>, linux-xfs <linux-xfs@...r.kernel.org>, Linux Crypto Mailing List <linux-crypto@...r.kernel.org>, device-mapper development <dm-devel@...hat.com> Subject: Re: Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs On Thu, Mar 03, 2022 at 10:27:47AM +1200, Herbert Xu wrote: > On Wed, Mar 02, 2022 at 03:56:36PM +0100, Greg KH wrote: > > > > > If not, then these are the patches that should be backported: > > > 7bcb2c99f8ed crypto: algapi - use common mechanism for inheriting flags > > > 2eb27c11937e crypto: algapi - add NEED_FALLBACK to INHERITED_FLAGS > > > fbb6cda44190 crypto: algapi - introduce the flag CRYPTO_ALG_ALLOCATES_MEMORY > > > b8aa7dc5c753 crypto: drivers - set the flag CRYPTO_ALG_ALLOCATES_MEMORY > > > cd74693870fb dm crypt: don't use drivers that have CRYPTO_ALG_ALLOCATES_MEMORY > > > Herbert, correct me if I'm wrong here. > > > > These need to be manually backported as they do not apply cleanly. Can > > you provide such a set? Or should I just disable a specific driver here > > instead which would be easier overall? > > I think the safest thing is to disable qat in stable (possibly only > when DM_CRYPT is enabled/modular). The patches in question while > good may have too wide an effect for the stable kernel series. > > Giovanni, could you send Greg a Kconfig patch to do that? I was thinking, as an alternative, to lower the cra_priority in the QAT driver for the algorithms used by dm-crypt so they are not used by default. Is that a viable option? Sure, I can provide a patch for either the cra_priority or the Kconfig option for the stable kernels that don't have the patches above. -- Giovanni
Powered by blists - more mailing lists