lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <Yh8Bsk9RSm22Yr8d@owl.dominikbrodowski.net> Date: Wed, 2 Mar 2022 06:33:38 +0100 From: Dominik Brodowski <linux@...inikbrodowski.net> To: "Jason A. Donenfeld" <Jason@...c4.com> Cc: linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org, netdev@...r.kernel.org, Alexander Graf <graf@...zon.com>, Jann Horn <jannh@...gle.com>, Greg KH <gregkh@...uxfoundation.org>, Theodore Ts'o <tytso@....edu> Subject: Re: [PATCH 1/3] random: replace custom notifier chain with standard one Am Wed, Mar 02, 2022 at 12:10:36AM +0100 schrieb Jason A. Donenfeld: > /* > * Delete a previously registered readiness callback function. > */ > -void del_random_ready_callback(struct random_ready_callback *rdy) > +int unregister_random_ready_notifier(struct notifier_block *nb) > { > unsigned long flags; > - struct module *owner = NULL; > - > - spin_lock_irqsave(&random_ready_list_lock, flags); > - if (!list_empty(&rdy->list)) { > - list_del_init(&rdy->list); > - owner = rdy->owner; > - } > - spin_unlock_irqrestore(&random_ready_list_lock, flags); > + int ret; > > - module_put(owner); > + spin_lock_irqsave(&random_ready_chain_lock, flags); > + ret = raw_notifier_chain_unregister(&random_ready_chain, nb); > + spin_unlock_irqrestore(&random_ready_chain_lock, flags); > + return ret; > } > -EXPORT_SYMBOL(del_random_ready_callback); That doesn't seem to be used anywhere, so I'd suggest removing this function altogether. Otherwise: Reviewed-by: Dominik Brodowski <linux@...inikbrodowski.net>
Powered by blists - more mailing lists