linux-kernel - Re: Re: [PATCH v2] ASoC: fsi: Add check for clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed,  2 Mar 2022 14:25:05 +0800
From:   Jiasheng Jiang <jiasheng@...as.ac.cn>
To:     kuninori.morimoto.gx@...esas.com
Cc:     broonie@...nel.org, lgirdwood@...il.com, perex@...ex.cz,
        tiwai@...e.com, ast@...nel.org, daniel@...earbox.net,
        andrii@...nel.org, kafai@...com, songliubraving@...com, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org, f.suligoi@...m.it,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        Jiasheng Jiang <jiasheng@...as.ac.cn>
Subject: Re: Re: [PATCH v2] ASoC: fsi: Add check for clk_enable

On Wed, Mar 02, 2022 at 12:35:02PM +0800, Kuninori Morimoto wrote:
>> +disable_xck:
>> +	clk_disable(clock->xck);
>> +disable_ick:
>> +	clk_disable(clock->ick);
>> +err:
>> +	return ret;
>>  }
> 
> I think disable_ick() / disable_xck() order are inverted ?

Thanks, I will submit a v3 to solve it.

Jiang