linux-kernel - [PATCH] goldfish_pipe: Use platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed,  2 Mar 2022 14:49:28 +0800
From:   sujiaxun <sujiaxun@...ontech.com>
To:     jack@...e.cz
Cc:     ira.weiny@...el.com, alex.williamson@...hat.com,
        linux-kernel@...r.kernel.org, sujiaxun <sujiaxun@...ontech.com>
Subject: [PATCH] goldfish_pipe: Use platform_get_irq() to get the interrupt

platform_get_resource(pdev, IORESOURCE_IRQ, ..) relies on static
allocation of IRQ resources in DT core code, this causes an issue
when using hierarchical interrupt domains using "interrupts" property
in the node as this bypassed the hierarchical setup and messed up the
irq chaining.

In preparation for removal of static setup of IRQ resource from DT core
code use platform_get_irq().

Signed-off-by: sujiaxun <sujiaxun@...ontech.com>
---
 drivers/platform/goldfish/goldfish_pipe.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/goldfish/goldfish_pipe.c b/drivers/platform/goldfish/goldfish_pipe.c
index b67539f9848c..0256f76dfe5d 100644
--- a/drivers/platform/goldfish/goldfish_pipe.c
+++ b/drivers/platform/goldfish/goldfish_pipe.c
@@ -896,12 +896,10 @@ static int goldfish_pipe_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}

-	r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-	if (!r)
+	dev->irq = platform_get_irq(pdev, 0);
+	if (dev->irq < 0)
 		return -EINVAL;

-	dev->irq = r->start;
-
 	/*
 	 * Exchange the versions with the host device
 	 *
--
2.20.1