linux-kernel - Re: [PATCH] arm64: dts: qcom: Drop bogus interrupt flags cell on MDSS nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqK54f11oEHDLOuCbPBD9ix16sA43074mfQAcyvBpwXV+A@mail.gmail.com>
Date:   Tue, 1 Mar 2022 19:23:27 -0600
From:   Rob Herring <robh@...nel.org>
To:     Marijn Suijten <marijn.suijten@...ainline.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: Drop bogus interrupt flags cell on MDSS nodes

On Tue, Mar 1, 2022 at 4:24 PM Marijn Suijten
<marijn.suijten@...ainline.org> wrote:
>
> Hi Rob,
>
> On 2022-03-01 15:05:31, Rob Herring wrote:
> > The MDSS interrupt provider is a single cell, so specifying interrupt flags
> > on the consumers is incorrect.
>
> There seem to be many more violators of `#interrupt-cells = <1>;`, at
> least on -next e6ada6df471f.  It seems those are not intentionally
> omitted in this patch?  Searching for `interrupt-parent = <&mdss>;`
> globally and evaluating `interrupts =` right next to it yields:
>
> - Two more hits in both sdm845.dtsi and sm8250.dtsi;
> - qcom-msm8974.dtsi;
> - msm8996.dtsi;
> - sdm630.dtsi;
> - sdm660.dtsi.
>
> And for the docs patch:
> - mdp5.txt;

Don't care, it's a .txt file.

> - And the recently added dpu-qcm2290.yaml, whose CI failure might have
>   exactly lead to this patch?
>
> Would you mind cleaning these up in a v2, or otherwise explain and
> forgive my ignorance for not seeing why these were not changed?

For the rest, just inadequate searching on my part. v2 coming soon.

Rob