linux-kernel - Re: [PATCH 2/9] mm/z3fold: remove obsolete comment in z3fold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM4kBB+PGgRqmkXOVCv+Cvv8CAE_apK5n9asL6JSfuxeS5-RcQ@mail.gmail.com>
Date:   Wed, 2 Mar 2022 09:18:48 +0100
From:   Vitaly Wool <vitaly.wool@...sulko.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linux-MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/9] mm/z3fold: remove obsolete comment in z3fold_alloc

On Sat, Feb 19, 2022 at 10:26 AM Miaohe Lin <linmiaohe@...wei.com> wrote:
>
> The highmem pages are supported since commit f1549cb5ab2b ("mm/z3fold.c:
> allow __GFP_HIGHMEM in z3fold_alloc"). Remove the residual comment.
>
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Reviewed-by: Vitaly Wool <vitaly.wool@...sulko.com>

> ---
>  mm/z3fold.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/mm/z3fold.c b/mm/z3fold.c
> index e86aafea6599..87689f50f709 100644
> --- a/mm/z3fold.c
> +++ b/mm/z3fold.c
> @@ -1064,9 +1064,6 @@ static void z3fold_destroy_pool(struct z3fold_pool *pool)
>   * performed first. If no suitable free region is found, then a new page is
>   * allocated and added to the pool to satisfy the request.
>   *
> - * gfp should not set __GFP_HIGHMEM as highmem pages cannot be used
> - * as z3fold pool pages.
> - *
>   * Return: 0 if success and handle is set, otherwise -EINVAL if the size or
>   * gfp arguments are invalid or -ENOMEM if the pool was unable to allocate
>   * a new page.
> --
> 2.23.0
>