linux-kernel - Re: [PATCH] ALSA: intel_hdmi: Fix reference to PCM buffer address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 02 Mar 2022 09:27:45 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Zhen Ni <nizhen@...ontech.com>
Cc:     perex@...ex.cz, tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: intel_hdmi: Fix reference to PCM buffer address

On Wed, 02 Mar 2022 08:42:41 +0100,
Zhen Ni wrote:
> 
> PCM buffers might be allocated dynamically when the buffer
> preallocation failed or a larger buffer is requested, and it's not
> guaranteed that substream->dma_buffer points to the actually used
> buffer.  The driver needs to refer to substream->runtime->dma_addr
> instead for the buffer address.
> 
> Signed-off-by: Zhen Ni <nizhen@...ontech.com>

Thanks, applied now with Cc-to-stable.

I guess the had_pcm_mmap() can be dropped completely and replaced with
the standard mmap helper, as what we really want is rather wc.
But it can be done for 5.18.


Takashi