linux-kernel - Re: [PATCH] objtool: Fix memory leak in objtool_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2203021008340.5895@pobox.suse.cz>
Date:   Wed, 2 Mar 2022 10:09:46 +0100 (CET)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Zong Cao <cz18811105578@...il.com>
cc:     jpoimboe@...hat.com, peterz@...radead.org, mingo@...nel.org,
        bp@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] objtool: Fix memory leak in objtool_create_backup

Hi,

On Wed, 2 Mar 2022, cz18811105578@...il.com wrote:

> From: Zong Cao <cz18811105578@...il.com>
> 
> The error handling branch did not properly free the memory before
> return, which would cause memory leak.

yes, but objtool exits immediately in those cases so this is not really 
needed in the end.

Regards
Miroslav