linux-kernel - RE: [PATCH 1/3] cpufreq: amd-pstate: Add more tracepoint for AMD P-State module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <MWHPR1201MB24943F2D2F382D13B5447D9890039@MWHPR1201MB2494.namprd12.prod.outlook.com>
Date:   Wed, 2 Mar 2022 09:53:12 +0000
From:   "Su, Jinzhou (Joe)" <Jinzhou.Su@....com>
To:     "Huang, Ray" <Ray.Huang@....com>,
        "Rafael J. Wysocki" <rafael@...nel.org>
CC:     "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux PM <linux-pm@...r.kernel.org>,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Doug Smythies <dsmythies@...us.net>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Todd Brandt <todd.e.brandt@...ux.intel.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Sharma, Deepak" <Deepak.Sharma@....com>,
        "Du, Xiaojian" <Xiaojian.Du@....com>,
        "Yuan, Perry" <Perry.Yuan@....com>,
        "Meng, Li (Jassmine)" <Li.Meng@....com>
Subject: RE: [PATCH 1/3] cpufreq: amd-pstate: Add more tracepoint for AMD
 P-State module

[AMD Official Use Only]

Comment in line.

Regards,
Joe

> -----Original Message-----
> From: Huang, Ray <Ray.Huang@....com>
> Sent: Wednesday, March 2, 2022 5:09 PM
> To: Rafael J. Wysocki <rafael@...nel.org>; Su, Jinzhou (Joe)
> <Jinzhou.Su@....com>
> Cc: Deucher, Alexander <Alexander.Deucher@....com>; Rafael J. Wysocki
> <rjw@...ysocki.net>; Linux PM <linux-pm@...r.kernel.org>; Srinivas
> Pandruvada <srinivas.pandruvada@...ux.intel.com>; Doug Smythies
> <dsmythies@...us.net>; Viresh Kumar <viresh.kumar@...aro.org>; Todd
> Brandt <todd.e.brandt@...ux.intel.com>; Linux Kernel Mailing List <linux-
> kernel@...r.kernel.org>; Sharma, Deepak <Deepak.Sharma@....com>; Du,
> Xiaojian <Xiaojian.Du@....com>; Yuan, Perry <Perry.Yuan@....com>;
> Meng, Li (Jassmine) <Li.Meng@....com>
> Subject: Re: [PATCH 1/3] cpufreq: amd-pstate: Add more tracepoint for AMD P-
> State module
>
> On Wed, Mar 02, 2022 at 12:07:45AM +0800, Rafael J. Wysocki wrote:
> > On Tue, Mar 1, 2022 at 5:05 PM Deucher, Alexander
> > <Alexander.Deucher@....com> wrote:
> > >
> > > [AMD Official Use Only]
> > >
> > > > -----Original Message-----
> > > > From: Rafael J. Wysocki <rafael@...nel.org>
> > > > Sent: Tuesday, March 1, 2022 10:26 AM
> > > > To: Su, Jinzhou (Joe) <Jinzhou.Su@....com>
> > > > Cc: Rafael J. Wysocki <rjw@...ysocki.net>; Linux PM <linux-
> > > > pm@...r.kernel.org>; Srinivas Pandruvada
> > > > <srinivas.pandruvada@...ux.intel.com>; Doug Smythies
> > > > <dsmythies@...us.net>; Huang, Ray <Ray.Huang@....com>; Viresh
> > > > Kumar <viresh.kumar@...aro.org>; Todd Brandt
> > > > <todd.e.brandt@...ux.intel.com>; Linux Kernel Mailing List
> > > > <linux-kernel@...r.kernel.org>; Sharma, Deepak
> > > > <Deepak.Sharma@....com>; Deucher, Alexander
> > > > <Alexander.Deucher@....com>; Du, Xiaojian <Xiaojian.Du@....com>;
> > > > Yuan, Perry <Perry.Yuan@....com>; Meng, Li (Jassmine)
> > > > <Li.Meng@....com>
> > > > Subject: Re: [PATCH 1/3] cpufreq: amd-pstate: Add more tracepoint
> > > > for AMD P-State module
> > > >
> > > > On Wed, Feb 23, 2022 at 11:04 AM Jinzhou Su <Jinzhou.Su@....com>
> > > > wrote:
> > > > >
> > > > > Add frequency, mperf, aperf and tsc in the trace. This can be
> > > > > used to debug and tune the performance of AMD P-state driver.
> > > > >
> > > > > Use the time difference between amd_pstate_update to calculate
> > > > > CPU frequency. There could be sleep in arch_freq_get_on_cpu, so
> > > > > do not use it here.
> > > > >
> > > > > Signed-off-by: Jinzhou Su <Jinzhou.Su@....com>
> > > > > Signed-off-by: Huang Rui <ray.huang@....com>
> > > >
> > > > I'm not sure what the second sign-off is for.
> > > >
> > > > If this is a maintainer's sign-off, it should be added by the
> > > > maintainer himself and you should not add it when submitting the patch.
> > >
> > > Both developers co-worked on the patch.  Isn't that pretty standard when
> you rework someone else's patch?
> >
> > It is, but that's when Co-developed-by should be used.  Otherwise the
> > meaning of the second s-o-b is unclear.
>
> Yes.
>
> Joe, can you add below in next V2:
>
> Co-developed-by: Huang Rui <ray.huang@....com>
>
> Patch looks good for me, could you please add new patch to describe how to
> use the tracer script in Documentation/admin-guide/pm/amd-pstate.rst?

Ok, will do that later.

Joe
>
> Thanks,
> Ray