linux-kernel - Re: [PATCH v2 1/2] arm: dts: mediatek: Format mediatek,larbs as an array of phandles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <00c646de-053c-d84f-cb70-e33060264d40@gmail.com>
Date:   Wed, 2 Mar 2022 10:59:29 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>
Cc:     Rob Herring <robh+dt@...nel.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>, kernel@...labora.com,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 1/2] arm: dts: mediatek: Format mediatek,larbs as an
 array of phandles



On 01/03/2022 21:31, Nícolas F. R. A. Prado wrote:
> Commit 39bd2b6a3783 ("dt-bindings: Improve phandle-array schemas")
> updated the mediatek,larbs property in the mediatek,iommu.yaml
> dt-binding to make it clearer that the phandles passed to the property
> are independent, rather than subsequent arguments to the first phandle.
> 
> Update the mediatek,larbs property in the arm Devicetrees to use the
> same formatting. This change doesn't impact any behavior: the compiled
> dtb is exactly the same. It does however fix the warnings generated by
> dtbs_check.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> 

Applied, thanks!

Matthias

> ---
> v1: https://lore.kernel.org/linux-mediatek/20220225225315.80220-1-nfraprado@collabora.com/
> 
> Changes in v2:
> - Split arm and arm64 changes into separate commits
> 
>   arch/arm/boot/dts/mt2701.dtsi  | 2 +-
>   arch/arm/boot/dts/mt7623n.dtsi | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi
> index 4776f85d6d5b..64722285228c 100644
> --- a/arch/arm/boot/dts/mt2701.dtsi
> +++ b/arch/arm/boot/dts/mt2701.dtsi
> @@ -222,7 +222,7 @@ iommu: mmsys_iommu@...05000 {
>   		interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_LOW>;
>   		clocks = <&infracfg CLK_INFRA_M4U>;
>   		clock-names = "bclk";
> -		mediatek,larbs = <&larb0 &larb1 &larb2>;
> +		mediatek,larbs = <&larb0>, <&larb1>, <&larb2>;
>   		#iommu-cells = <1>;
>   	};
>   
> diff --git a/arch/arm/boot/dts/mt7623n.dtsi b/arch/arm/boot/dts/mt7623n.dtsi
> index bcb0846e29fd..f9e031621c80 100644
> --- a/arch/arm/boot/dts/mt7623n.dtsi
> +++ b/arch/arm/boot/dts/mt7623n.dtsi
> @@ -107,7 +107,7 @@ iommu: mmsys_iommu@...05000 {
>   		interrupts = <GIC_SPI 106 IRQ_TYPE_LEVEL_LOW>;
>   		clocks = <&infracfg CLK_INFRA_M4U>;
>   		clock-names = "bclk";
> -		mediatek,larbs = <&larb0 &larb1 &larb2>;
> +		mediatek,larbs = <&larb0>, <&larb1>, <&larb2>;
>   		#iommu-cells = <1>;
>   	};
>