linux-kernel - Re: [PATCH net-next] tuntap: add sanity checks about msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220301180512.06f7f6dc@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 1 Mar 2022 18:05:12 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Harold Huang <baymaxhuang@...il.com>
Cc:     netdev@...r.kernel.org, jasowang@...hat.com, edumazet@...gle.com,
        Eric Dumazet <eric.dumazet@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        linux-kernel@...r.kernel.org (open list),
        kvm@...r.kernel.org (open list:VIRTIO HOST (VHOST)),
        virtualization@...ts.linux-foundation.org (open list:VIRTIO HOST 
        (VHOST)), bpf@...r.kernel.org (open list:XDP (eXpress Data Path))
Subject: Re: [PATCH net-next] tuntap: add sanity checks about msg_controllen
 in sendmsg

On Tue,  1 Mar 2022 14:43:14 +0800 Harold Huang wrote:
> In patch [1], tun_msg_ctl was added to allow pass batched xdp buffers to
> tun_sendmsg. Although we donot use msg_controllen in this path, we should
> check msg_controllen to make sure the caller pass a valid msg_ctl.
> 
> [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fe8dd45bb7556246c6b76277b1ba4296c91c2505
> 
> Reported-by: Eric Dumazet <eric.dumazet@...il.com>
> Suggested-by: Jason Wang <jasowang@...hat.com>
> Signed-off-by: Harold Huang <baymaxhuang@...il.com>

Would you mind resending the same patch? It looks like it depended on
your other change so the build bot was unable to apply and test it.