linux-kernel - Re: [PATCH] ice: use msleep instead of mdelay

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220301181059.27021dbb@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 1 Mar 2022 18:10:59 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jonathan Toppins <jtoppins@...hat.com>
Cc:     intel-wired-lan@...ts.osuosl.org, lihong.yang@...el.com,
        Jocelyn Falempe <jfalempe@...hat.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ice: use msleep instead of mdelay

On Tue,  1 Mar 2022 09:48:45 -0500 Jonathan Toppins wrote:
> Use msleep for long delays instead of spinning in the driver.

You should add the justification for why sleeping / scheduling out 
is okay in these particular spots to the commit message.