linux-kernel - Re: 回复：[PATCH -next] ASoC: amd: Fix an ignored error return from platform_get_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Yh9tEYtfKTBIICQS@sirena.org.uk>
Date:   Wed, 2 Mar 2022 13:11:45 +0000
From:   Mark Brown <broonie@...nel.org>
To:     "Yang.Lee" <yang.lee@...ux.alibaba.com>
Cc:     lgirdwood <lgirdwood@...il.com>, perex <perex@...ex.cz>,
        tiwai <tiwai@...e.com>, tangmeng <tangmeng@...ontech.com>,
        alsa-devel <alsa-devel@...a-project.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: 回复：[PATCH -next] ASoC: amd: Fix an ignored error return from
 platform_get_irq_byname()

On Wed, Mar 02, 2022 at 09:17:21AM +0800, Yang.Lee wrote:

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

> The function dev_err_probe() is called in function platform_get_irq_byname() to print the error code.

That doesn't seem at all relevant to the error code being returned which
is what the review feedback was about:

> > If an error code is being returned we should report that error code
> > rather than squashing it down to -ENODEV.

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)